[Getan-commits] [PATCH 1 of 2] Fix loading entries of a project

Wald Commits scm-commit at wald.intevation.org
Mon Mar 3 15:08:34 CET 2014


# HG changeset patch
# User Björn Ricks <bjoern.ricks at intevation.de>
# Date 1393855687 -3600
# Node ID 90c09cca49c391d63eb23fb595ff482d4e226c74
# Parent  2373618e787db4dbfc0f777de49b8a16a26f5ed3
Fix loading entries of a project

Projects.entries is converted into a read only property. Therefore it is not
allowed to set the entries directly. Instead the load_entries method must be
used.

diff -r 2373618e787d -r 90c09cca49c3 getan/backend.py
--- a/getan/backend.py	Mon Mar 03 15:00:20 2014 +0100
+++ b/getan/backend.py	Mon Mar 03 15:08:07 2014 +0100
@@ -290,7 +290,7 @@
             logger.debug("Added new entry '%s' of project '%s' into db"
                          % (desc, project.desc))
 
-            project.entries = self.load_entries(project.id)
+            project.load_entries()
         finally:
             close(cur)
 
diff -r 2373618e787d -r 90c09cca49c3 getan/controller.py
--- a/getan/controller.py	Mon Mar 03 15:00:20 2014 +0100
+++ b/getan/controller.py	Mon Mar 03 15:08:07 2014 +0100
@@ -68,11 +68,10 @@
         logger.debug("GetanController: update entries for project %s." %
                      project.id)
 
-        entries = self.backend.load_entries(project.id)
-        project.entries = entries
+        project.load_entries()
 
         if self.view:
-            self.view.update_entries(entries)
+            self.view.update_entries(project.entries)
 
     def move_entry(self, entry, project):
         self.move_entries([entry], project)
@@ -80,7 +79,6 @@
     def move_entries(self, entries, project):
         old_project = self.project_by_id(entries[0].project_id)
         self.backend.move_entries(entries, project.id)
-        project.entries = self.backend.load_entries(project.id)
         self.update_entries(old_project)
         self.project_view.update_rows()
 


More information about the Getan-commits mailing list