[Lada-commits] [PATCH 1 of 2] Removed most log messages to make the application less verbose

Wald Commits scm-commit at wald.intevation.org
Thu Nov 6 11:20:19 CET 2014


# HG changeset patch
# User Raimund Renkert <raimund.renkert at intevation.de>
# Date 1415268741 -3600
# Node ID 8b4ec61c5752013907ed1bf9f68ca4763707dfb8
# Parent  c1b77fb96b01fd7bc69223de8e9923310fedbfc1
Removed most log messages to make the application less verbose.

diff -r c1b77fb96b01 -r 8b4ec61c5752 app.js
--- a/app.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app.js	Thu Nov 06 11:12:21 2014 +0100
@@ -55,7 +55,6 @@
 
     // Start the application.
     launch: function() {
-        console.log('Launching the application');
         Ext.create('Lada.store.StaDatenbasen', {
             storeId: 'staDatenbasen'
         });
@@ -115,7 +114,6 @@
 Ext.data.writer.Json.override({
     getRecordData: function(record) {
         if (this.writeEverything || record.writeEverything) {
-            console.log('getRecordData', arguments);
             return record.getAllData();
         }
         return this.callOverridden(arguments);
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/controller/Base.js
--- a/app/controller/Base.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/controller/Base.js	Thu Nov 06 11:12:21 2014 +0100
@@ -46,7 +46,6 @@
      * the user clicks on the "Save" button
      */
     saveItem: function(button) {
-        console.log('Saving ...');
         var form = button.up('window').down('form');
         form.commit();
     },
@@ -87,10 +86,6 @@
                         store.reload();
                     }
                 });
-                console.log('Deleting ' + selection);
-            }
-            else {
-                console.log('Cancel Deleting ' + selection);
             }
         });
     },
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/controller/Kommentare.js
--- a/app/controller/Kommentare.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/controller/Kommentare.js	Thu Nov 06 11:12:21 2014 +0100
@@ -25,7 +25,6 @@
     ],
 
     init: function() {
-        console.log('Initialising the Kommentare controller');
         this.callParent();
     },
 
@@ -51,7 +50,6 @@
     },
 
     addItem: function(button) {
-        console.log('Adding new Kommentar for Probe ' + button.probeId);
         var kommentar = Ext.create('Lada.model.KommentarP');
         kommentar.set('probeId', button.probeId);
         Ext.widget('kommentarecreate', {
@@ -60,9 +58,7 @@
     },
 
     editItem: function(grid, record) {
-        console.log('Editing Kommentar');
         record.getAuthInfo(this.initEditWindow);
-        console.log('Loaded Kommentar with ID ' + record.getId());
     },
 
     initEditWindow: function(record, readonly) {
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/controller/MKommentare.js
--- a/app/controller/MKommentare.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/controller/MKommentare.js	Thu Nov 06 11:12:21 2014 +0100
@@ -25,7 +25,6 @@
     ],
 
     init: function() {
-        console.log('Initialising the MKommentare controller');
         this.callParent(arguments);
     },
 
@@ -60,11 +59,9 @@
     },
 
     editItem: function(grid, record) {
-        console.log('Editing Kommentar');
         var mstore = Ext.data.StoreManager.get('Messungen');
         var messung = mstore.getById(record.get('messungsId'));
         record.getAuthInfo(this.initEditWindow, messung.get('probeId'));
-        console.log('Loaded MKommentar with ID ' + record.getId());
     },
 
     initEditWindow: function(record, readonly) {
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/controller/Messungen.js
--- a/app/controller/Messungen.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/controller/Messungen.js	Thu Nov 06 11:12:21 2014 +0100
@@ -26,7 +26,6 @@
     ],
 
     init: function() {
-        console.log('Initialising the Messungen controller');
         this.callParent();
     },
 
@@ -59,13 +58,11 @@
     },
 
     saveItem: function(button) {
-        console.log('Saving new Messung for Probe ' + button.probeId);
         var form = button.up('window').down('form');
         form.commit();
     },
 
     addItem: function(button) {
-        console.log('Adding new Messung for Probe ' + button.probeId);
         var messung = Ext.create('Lada.model.Messung');
         messung.set('probeId', button.probeId);
         Ext.widget('messungencreate', {
@@ -74,7 +71,6 @@
     },
 
     editItem: function(grid, record) {
-        console.log('Editing Messung');
         var kstore = this.getKommentareMStore();
         kstore.load({
             params: {
@@ -97,7 +93,6 @@
             }
         });
         record.getAuthInfo(this.initEditWindow);
-        console.log('Loaded Messung with ID ' + record.getId());
     },
 
     initEditWindow: function(record, readonly, owner) {
@@ -129,10 +124,6 @@
                         store.reload();
                     }
                 });
-                console.log('Deleting Messung');
-            }
-            else {
-                console.log('Cancel Deleting Messung');
             }
         });
     },
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/controller/Messwert.js
--- a/app/controller/Messwert.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/controller/Messwert.js	Thu Nov 06 11:12:21 2014 +0100
@@ -23,7 +23,6 @@
     ],
 
     init: function() {
-        console.log('Initialising the Messwert controller');
         this.callParent(arguments);
     },
 
@@ -49,7 +48,6 @@
     },
 
     saveItem: function(button) {
-        console.log('Saving MesswerMesswert');
         var form = button.up('window').down('form');
         form.commit();
     },
@@ -64,11 +62,9 @@
     },
 
     editItem: function(grid, record) {
-        console.log('Editing Messwert');
         var mstore = Ext.data.StoreManager.get('Messungen');
         var messung = mstore.getById(record.get('messungsId'));
         record.getAuthInfo(this.initEditWindow, messung.get('probeId'));
-        console.log('Loaded Messwert with ID ' + record.getId());
     },
 
     initEditWindow: function(record, readonly) {
@@ -96,10 +92,6 @@
                         store.reload();
                     }
                 });
-                console.log('Deleting Messwert');
-            }
-            else {
-                console.log('Cancel Deleting Messwert');
             }
         });
     },
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/controller/Orte.js
--- a/app/controller/Orte.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/controller/Orte.js	Thu Nov 06 11:12:21 2014 +0100
@@ -27,7 +27,6 @@
     ],
 
     init: function() {
-        console.log('Initialising the Orte controller');
         this.callParent(arguments);
     },
 
@@ -63,14 +62,11 @@
     },
 
     createOrt: function() {
-        console.log('button clicked');
         var win = Ext.create('Lada.view.orte.CreateOrt', {});
         win.show();
     },
 
     saveNewOrt: function(button) {
-        console.log('button clicked');
-
         var form = button.up('window').down('form').getForm();
         var ortdetailstore = Ext.getStore('Ortedetails');
         var ortdetail = Ext.create('Lada.model.Ortdetail');
@@ -85,23 +81,18 @@
         ortdetailstore.add(ortdetail);
         ortdetailstore.sync({
             success: function(batch) {
-                console.log(batch);
                 var od = Ext.ComponentQuery.query('ortdetail');
-                console.log(od);
                 var response = batch.operations[0].resultSet.records[0].data;
                 od[0].setValue(response.ortId);
-                console.log('id:' + response.ortId);
                 button.up('window').close();
             },
             failure: function() {
-                console.log('Error on saving Ortdetails');
                 ortdetailstore.remove(ortdetail);
             }
         });
     },
 
     saveItem: function(button) {
-        console.log('Saving Ort');
         var form = button.up('window').down('form');
         var fform = form.getForm();
 
@@ -112,13 +103,11 @@
         var ortidfield = fform.findField('ortId');
         var ortid = ortidfield.getValue();
         if (ortid === null) {
-            console.log('New Ortdetail');
             ortdetail = Ext.create('Lada.model.Ortdetail');
             ortdetailstore.add(ortdetail);
             newortdetail = true;
         }
         else {
-            console.log('Editing Ortdetail');
             ortdetail = ortdetailstore.getById(ortid);
         }
 
@@ -143,14 +132,12 @@
                 ortidfield.setValue(ortid);
             },
             failure: function() {
-                console.log('Error on saving Ortdetails');
             }
         });
         form.commit();
     },
 
     addItem: function(button) {
-        console.log('Adding new Ort for Probe ' + button.probeId);
         var ort = Ext.create('Lada.model.Ort');
         ort.set('probeId', button.probeId);
         Ext.widget('ortecreate', {
@@ -159,9 +146,7 @@
     },
 
     editItem: function(grid, record) {
-        console.log('Editing Ort');
         record.getAuthInfo(this.initEditWindow);
-        console.log('Loaded Ort with ID ' + record.getId());
     },
 
     initEditWindow: function(record, readonly) {
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/controller/Proben.js
--- a/app/controller/Proben.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/controller/Proben.js	Thu Nov 06 11:12:21 2014 +0100
@@ -108,7 +108,6 @@
     ],
 
     init: function() {
-        console.log('Initialising the Proben controller');
         this.callParent(arguments);
     },
 
@@ -147,7 +146,6 @@
     },
 
     addItem: function() {
-        console.log('Adding new Probe');
         Ext.widget('probencreate');
     },
 
@@ -156,7 +154,6 @@
      * @private
      */
     selectUploadFile: function() {
-        console.log('Importing');
         Ext.widget('probenimport');
     },
 
@@ -210,7 +207,6 @@
                 value: selection[i].get('probeId')
             });
         }
-        console.log('create download form.');
         var hiddenForm = Ext.create('Ext.form.Panel', {
             title: 'hiddenForm',
             standardSubmit: true,
@@ -225,9 +221,7 @@
     },
 
     editItem: function(grid, record) {
-        console.log('Editing Probe');
         var id = record.get('id');
-        console.log('id is: ' + id);
         // Load Zusatzwerte
         var pstore = Ext.data.StoreManager.get('staProbenzusaetze');
         pstore.load();
@@ -262,7 +256,6 @@
             modelId: id
         });
         view.show();
-        console.log('Loaded Probe with ID ' + record.getId());
     },
 
     createSuccess: function(form, record, response) {
@@ -275,7 +268,6 @@
             store.load({
                 scope: this,
                 callback: function() {
-                    console.log('Loaded store');
                     // Open Editdialog
                     var json = Ext.decode(response.responseText);
                     if (json) {
@@ -290,7 +282,6 @@
             store.reload({
                 scope: this,
                 callback: function() {
-                    console.log('Reloaded store');
                     // Open Editdialog
                     var json = Ext.decode(response.responseText);
                     if (json) {
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/controller/Sql.js
--- a/app/controller/Sql.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/controller/Sql.js	Thu Nov 06 11:12:21 2014 +0100
@@ -30,7 +30,6 @@
     ],
 
     init: function() {
-        console.log('Initialising the Sql controller');
         this.control({
             // CSS like selector to select element in the viewport. See
             // ComponentQuery documentation for more details.
@@ -103,28 +102,24 @@
             var multi = filterFields[j].multiSelect;
             var field = null;
             if (type == "text") {
-                console.log("Found text filter");
                 field = Ext.create('Ext.form.field.Text', {
                     name: name,
                     fieldLabel: label
                 });
             }
             else if (type == "number") {
-                console.log("Found number filter");
                 field = Ext.create('Ext.form.field.Number', {
                     name: name,
                     fieldLabel: label
                 });
             }
             else if (type == "datetime") {
-                console.log("Found datetime filter");
                 field = Ext.create('Lada.view.widgets.Datetime', {
                     name: name,
                     fieldLabel: label
                 });
             }
             else if (type == "bool") {
-                console.log("Found bool filter");
                 field = Ext.create('Lada.view.widgets.Testdatensatz', {
                     name: name,
                     fieldLabel: label,
@@ -132,7 +127,6 @@
                 });
             }
             else if (type == "listmst") {
-                console.log("Found listmst filter");
                 field = Ext.create('Lada.view.widgets.Mst', {
                     name: name,
                     fieldLabel: label,
@@ -140,7 +134,6 @@
                 });
             }
             else if (type == "listumw") {
-                console.log("Found listumw filter");
                 field = Ext.create('Lada.view.widgets.Uwb', {
                     name: name,
                     fieldLabel: label,
@@ -148,7 +141,6 @@
                 });
             }
             else if (type == "listdbasis") {
-                console.log("Found listdbasis filter");
                 field = Ext.create('Lada.view.widgets.Datenbasis', {
                     name: name,
                     fieldLabel: label,
@@ -156,7 +148,6 @@
                 });
             }
             else if (type == "listver") {
-                console.log("Found listver filter");
                 field = Ext.create('Lada.view.widgets.Verwaltungseinheit', {
                     name: name,
                     fieldLabel: label,
@@ -164,7 +155,6 @@
                 });
             }
             else if (type == "listnetz") {
-                console.log("Found listnetz filter");
                 field = Ext.create('Lada.view.widgets.Netzbetreiber', {
                     name: name,
                     fieldLabel: label,
@@ -172,7 +162,6 @@
                 });
             }
             if (field) {
-                console.log("Pushing field to filters");
                 filters.add(field);
                 filters.show();
                 hide = false;
@@ -207,7 +196,6 @@
         result.getStore().load({
             params: searchParams
         });
-        console.log('Store loaded');
         result.show();
     },
 
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/controller/Status.js
--- a/app/controller/Status.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/controller/Status.js	Thu Nov 06 11:12:21 2014 +0100
@@ -18,7 +18,6 @@
     ],
 
     init: function() {
-        console.log('Initialising the Status controller');
         this.callParent(arguments);
     },
 
@@ -57,11 +56,9 @@
     },
 
     editItem: function(grid, record) {
-        console.log('Editing Status');
         var mstore = Ext.data.StoreManager.get('Messungen');
         var messung = mstore.getById(record.get('messungsId'));
         record.getAuthInfo(this.initEditWindow, messung.get('probeId'));
-        console.log("Loaded Status with ID " + record.getId()); //outputs ID
     },
 
     initEditWindow: function(record, readonly, owner) {
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/controller/Zusatzwerte.js
--- a/app/controller/Zusatzwerte.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/controller/Zusatzwerte.js	Thu Nov 06 11:12:21 2014 +0100
@@ -17,7 +17,6 @@
     ],
 
     init: function() {
-        console.log('Initialising the Zusatzwerte controller');
         this.callParent(arguments);
     },
 
@@ -47,13 +46,11 @@
     },
 
     saveItem: function(button) {
-        console.log('Saving new Zusatzwert for Probe ' + button.probeId);
         var form = button.up('window').down('form');
         form.commit();
     },
 
     addItem: function(button) {
-        console.log('Adding new Zusatzwert for Probe' + button.probeId);
         var zusatzwert = Ext.create('Lada.model.Zusatzwert');
         zusatzwert.set('probeId', button.probeId);
         Ext.widget('zusatzwertecreate', {
@@ -62,7 +59,6 @@
     },
 
     editItem: function(grid, record) {
-        console.log('Editing Zusatzwert');
         record.getAuthInfo(this.initEditWindow);
     },
 
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/model/Zusatzwert.js
--- a/app/model/Zusatzwert.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/model/Zusatzwert.js	Thu Nov 06 11:12:21 2014 +0100
@@ -55,7 +55,6 @@
         var zstore = Ext.data.StoreManager.get('staProbenzusaetze');
         var mstore = Ext.data.StoreManager.get('staMesseinheiten');
         var mehId = zstore.getById(pzsId).get('mehId');
-        console.log('mehid: ' + mehId);
         var record = mstore.getById(mehId);
         return record.get('einheit');
     }
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/view/Viewport.js
--- a/app/view/Viewport.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/view/Viewport.js	Thu Nov 06 11:12:21 2014 +0100
@@ -22,7 +22,6 @@
     ],
     layout: 'fit',
     initComponent: function() {
-        console.log('Setting up Viewport');
         this.initSearch();
 
         // Development related:
@@ -52,7 +51,6 @@
                 var userinfo = Ext.getCmp('userinfo');
                 userinfo.update(user);
                 groupinfo.update(groups);
-                console.log(info);
             }
         });
     },
@@ -124,9 +122,7 @@
                 probeId: probeId
             },
             callback: function() {
-                console.log(store);
                 var messung = store.data.items[0];
-                console.log(store.data.items[0]);
                 kstore.load({
                     params: {
                         probeId: probeId,
@@ -145,7 +141,6 @@
                         messungsId: messung.get('id').messungsId
                     }
                 });
-                console.log('Creating Messung window');
                 // var messung = Ext.create('Lada.model.Messung');
                 Ext.create('Lada.view.messungen.Create', {
                     model: messung
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/view/messwerte/List.js
--- a/app/view/messwerte/List.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/view/messwerte/List.js	Thu Nov 06 11:12:21 2014 +0100
@@ -62,7 +62,6 @@
             header: 'Messeinheit',
             dataIndex: 'mehId',
             renderer: function(value) {
-                console.log('einheit: ' + value);
                 var store = Ext.data.StoreManager.get('staMesseinheiten');
                 return store.findRecord('id', value).get('einheit');
             }
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/view/orte/CreateForm.js
--- a/app/view/orte/CreateForm.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/view/orte/CreateForm.js	Thu Nov 06 11:12:21 2014 +0100
@@ -56,7 +56,6 @@
                         });
                     }
 
-                    console.log('found verw');
                     var form = this.getForm();
                     var ffield = null;
                     if (ort) {
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/view/orte/List.js
--- a/app/view/orte/List.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/view/orte/List.js	Thu Nov 06 11:12:21 2014 +0100
@@ -61,7 +61,6 @@
             dataIndex: 'ortId',
             renderer: function(value) {
                 var store = Ext.data.StoreManager.get('staOrte');
-                console.log('value ' + value);
                 var record = store.getById(value);
                 return record.get('gemId');
             }
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/view/proben/Edit.js
--- a/app/view/proben/Edit.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/view/proben/Edit.js	Thu Nov 06 11:12:21 2014 +0100
@@ -25,7 +25,6 @@
     modal: true,
 
     initComponent: function() {
-        console.log('open edit...');
         this.buttons = [{
             text: 'Speichern',
             action: 'save'
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/view/widgets/LadaForm.js
--- a/app/view/widgets/LadaForm.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/view/widgets/LadaForm.js	Thu Nov 06 11:12:21 2014 +0100
@@ -114,7 +114,6 @@
                 callback: function(option, success, response) {
                     this.parseResponse(response);
                     if (this.success) {
-                        console.log('Save was successfull');
                         this.fireEvent(
                             'savesuccess',
                             this,
@@ -122,7 +121,6 @@
                             response);
                     }
                     else {
-                        console.log('Save was not successfull');
                         this.form.markInvalid(this.errors);
                         this.fireEvent(
                             'savefailure',
@@ -171,7 +169,6 @@
                 var ignore = false;
                 var k;
                 for (k = ignoreFields.length - 1; k >= 0; k--) {
-                    console.log(ignoreFields[k] + '===' + field.getName());
                     if (ignoreFields[k] === field.getName(true)) {
                         ignore = true;
                     }
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/view/zusatzwerte/CreateForm.js
--- a/app/view/zusatzwerte/CreateForm.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/view/zusatzwerte/CreateForm.js	Thu Nov 06 11:12:21 2014 +0100
@@ -25,8 +25,7 @@
             fieldLabel: 'PZW-Größe',
             listeners: {
                 scope: this,
-                'change': function(field, newv, oldv, opts) {
-                    console.log(field, oldv, newv, opts);
+                'change': function(field, newv, oldv) {
                     var ffield = this.getForm().findField('messeinheit');
                     var pzsId = newv;
                     if (!pzsId) {
diff -r c1b77fb96b01 -r 8b4ec61c5752 app/view/zusatzwerte/List.js
--- a/app/view/zusatzwerte/List.js	Thu Nov 06 10:59:03 2014 +0100
+++ b/app/view/zusatzwerte/List.js	Thu Nov 06 11:12:21 2014 +0100
@@ -74,7 +74,6 @@
             renderer: function(value) {
                 var zstore = Ext.data.StoreManager.get('staProbenzusaetze');
                 var mstore = Ext.data.StoreManager.get('staMesseinheiten');
-                console.log('store: ' + mstore);
                 var mehId = zstore.getById(value).get('mehId');
                 var record = mstore.findRecord('id', mehId);
                 return record.get('einheit');


More information about the Lada-commits mailing list