[Openvas-commits] r6103 - in trunk/openvas-client: . openvas

[scm-commit@wald.intevation.org]

Author: timb
Date: 2009-12-09 03:10:20 +0100 (Wed, 09 Dec 2009)
New Revision: 6103

Modified:
   trunk/openvas-client/ChangeLog
   trunk/openvas-client/openvas/nbe_output.c
Log:
Fixed potential resource leak and spotted a couple more


Modified: trunk/openvas-client/ChangeLog
===================================================================
--- trunk/openvas-client/ChangeLog	2009-12-09 01:52:44 UTC (rev 6102)
+++ trunk/openvas-client/ChangeLog	2009-12-09 02:10:20 UTC (rev 6103)
@@ -5,6 +5,8 @@
 	* openvas/prefs_dialog/prefs_scope_tree.c: Fixed potential resource
 	leak.
 
+	* openvas/nbe_output.c: Fixed potential resource leak.
+
 2009-12-07  Michael Wiegand <michael.wiegand at intevation.de>
 
 	Post-release version bump.

Modified: trunk/openvas-client/openvas/nbe_output.c
===================================================================
--- trunk/openvas-client/openvas/nbe_output.c	2009-12-09 01:52:44 UTC (rev 6102)
+++ trunk/openvas-client/openvas/nbe_output.c	2009-12-09 02:10:20 UTC (rev 6103)
@@ -31,6 +31,8 @@
  * @brief Initializes a backend with contents from a nbe report file (or stdin).
  * 
  * I.e. copy file contents to backends file.
+ *
+ * @todo Where does befd get cleaned up?  Also should check that initial open works
  * 
  * @param filename Filename of nbe file to import from or "-" for stdin.
  * 
@@ -65,6 +67,8 @@
  *
  * Does not handle the case where the backend is not
  * a file.
+ *
+ * @todo Where does befd get cleaned up?  Also should check that initial open works.
  * 
  * @param filename name of file or "-" for stdout.
  */
@@ -105,6 +109,7 @@
   if(e < 0)
    {
     perror("read ");
+    close(fd);
     return -1;
    }
   write(fd, buf, e);