[Openvas-commits] r6108 - in trunk/openvas-libraries: . misc

[scm-commit@wald.intevation.org]

Author: felix
Date: 2009-12-09 10:00:56 +0100 (Wed, 09 Dec 2009)
New Revision: 6108

Modified:
   trunk/openvas-libraries/ChangeLog
   trunk/openvas-libraries/misc/plugutils.c
Log:
* misc/plugutils.c: Added TODOs, lead to by compiler warnings of
openvas-scanner/cnvts/find_service.


Modified: trunk/openvas-libraries/ChangeLog
===================================================================
--- trunk/openvas-libraries/ChangeLog	2009-12-09 08:43:58 UTC (rev 6107)
+++ trunk/openvas-libraries/ChangeLog	2009-12-09 09:00:56 UTC (rev 6108)
@@ -1,5 +1,10 @@
 2009-12-09  Felix Wolfsteller <felix.wolfsteller at intevation.de>
 
+	* misc/plugutils.c: Added TODOs, lead to by compiler warnings of
+	openvas-scanner/cnvts/find_service.
+
+2009-12-09  Felix Wolfsteller <felix.wolfsteller at intevation.de>
+
 	* nasl/nasl_host.c: Removed extern function declarations.
 
 2009-12-09  Felix Wolfsteller <felix.wolfsteller at intevation.de>

Modified: trunk/openvas-libraries/misc/plugutils.c
===================================================================
--- trunk/openvas-libraries/misc/plugutils.c	2009-12-09 08:43:58 UTC (rev 6107)
+++ trunk/openvas-libraries/misc/plugutils.c	2009-12-09 09:00:56 UTC (rev 6108)
@@ -1658,10 +1658,19 @@
  plug_set_ssl_item(args, "password", key);
 }
 
+/** @TODO This function is only used in
+ *        openvas-scanner/cnvts/find_service/find_service.c (and implicitely
+ *        declared within there! -> compiler warning). Consider putting this
+ *        function in header and include it from find_services or move
+ *        functionality there if possible). */
+/** @TODO Also, all plug_set_ssl*-functions set values that are only accessed
+ *        in network.c:open_stream_connection under specific conditions.
+ *        Check whether these conditions can actually occur. Document the
+ *        functions on the way. */
 void
 plug_set_ssl_CA_file (struct arglist * args, char * key)
 {
- plug_set_ssl_item(args, "CA", key);
+ plug_set_ssl_item (args, "CA", key);
 }
 
 char *