[Openvas-commits] r2909 - in trunk/openvas-client: . nessus/prefs_dialog

[scm-commit@wald.intevation.org]

Author: felix
Date: 2009-03-26 08:52:37 +0100 (Thu, 26 Mar 2009)
New Revision: 2909

Modified:
   trunk/openvas-client/ChangeLog
   trunk/openvas-client/nessus/prefs_dialog/prefs_dialog_user.c
Log:
Use glibs functions instead of malloc + sprintf.

* nessus/prefs_dialog/prefs_dialog_user.c (add_rule_callback): Use
g_strdup_printf instead of emalloc + sprintf (one instance
accidentially commited with last commit).


Modified: trunk/openvas-client/ChangeLog
===================================================================
--- trunk/openvas-client/ChangeLog	2009-03-26 07:50:48 UTC (rev 2908)
+++ trunk/openvas-client/ChangeLog	2009-03-26 07:52:37 UTC (rev 2909)
@@ -1,5 +1,13 @@
 2009-03-26  Felix Wolfsteller <felix.wolfsteller at intevation.de>
 
+	Use glibs functions instead of malloc + sprintf.
+	
+	* nessus/prefs_dialog/prefs_dialog_user.c (add_rule_callback): Use
+	g_strdup_printf instead of emalloc + sprintf (one instance
+	accidentially commited with last commit).
+
+2009-03-26  Felix Wolfsteller <felix.wolfsteller at intevation.de>
+
 	Cosmetics in prefs_dialog_user module.
 	
 	* nessus/prefs_dialog/prefs_dialog_user.c: Added doc, reformatting.

Modified: trunk/openvas-client/nessus/prefs_dialog/prefs_dialog_user.c
===================================================================
--- trunk/openvas-client/nessus/prefs_dialog/prefs_dialog_user.c	2009-03-26 07:50:48 UTC (rev 2908)
+++ trunk/openvas-client/nessus/prefs_dialog/prefs_dialog_user.c	2009-03-26 07:52:37 UTC (rev 2909)
@@ -202,8 +202,6 @@
       !strcmp(action, "default deny") ||
       !strcmp(action, "default reject"))
     {
-      rule = emalloc(strlen(action)+1);
-      sprintf(rule, "%s", action);
       rule = g_strdup_printf ("%s", action);
     }
   else
@@ -213,8 +211,7 @@
           show_warning(_("The target for this rule must be a valid IP or Subnet.\n"));
           return;
         }
-     rule = emalloc(strlen(action)+strlen(target)+1+1);
-     sprintf(rule, "%s %s", action, target);
+      rule = g_strdup_printf ("%s %s", action, target);
     }
 
   /* add the rule to the list store */