[Openvas-commits] r5439 - in trunk/openvas-scanner: . openvassd

[scm-commit@wald.intevation.org]

Author: mwiegand
Date: 2009-10-08 11:41:23 +0200 (Thu, 08 Oct 2009)
New Revision: 5439

Modified:
   trunk/openvas-scanner/ChangeLog
   trunk/openvas-scanner/openvassd/otp_1_0.c
Log:
* openvassd/otp_1_0.c (otp_1_0_server_send_certificates): Added todo
for segfault on nonexistent public key.


Modified: trunk/openvas-scanner/ChangeLog
===================================================================
--- trunk/openvas-scanner/ChangeLog	2009-10-08 08:28:27 UTC (rev 5438)
+++ trunk/openvas-scanner/ChangeLog	2009-10-08 09:41:23 UTC (rev 5439)
@@ -1,3 +1,8 @@
+2009-10-08  Michael Wiegand <michael.wiegand at intevation.de>
+
+	* openvassd/otp_1_0.c (otp_1_0_server_send_certificates): Added todo
+	for segfault on nonexistent public key.
+
 2009-10-06  Tim Brown <timb at openvas.org>
 
 	* openvassd/utils.c: Fixed memory leak, typos and resource leak. Also added

Modified: trunk/openvas-scanner/openvassd/otp_1_0.c
===================================================================
--- trunk/openvas-scanner/openvassd/otp_1_0.c	2009-10-08 08:28:27 UTC (rev 5438)
+++ trunk/openvas-scanner/openvassd/otp_1_0.c	2009-10-08 09:41:23 UTC (rev 5439)
@@ -93,6 +93,10 @@
 
       // Replace newlines by semicolons
       gchar* pos = cert->public_key;
+      /** @todo This will segfault if the public key could not be retrieved.
+       * A solution would be to check if cert->public_key is NULL and try to
+       * recover if it is.
+       */
       while(pos[0] != '\0')
         {
         if(pos[0] == '\n') pos[0] = ';';