[Openvas-devel] Few questions about the code...

Jan-Oliver Wagner jan-oliver.wagner at intevation.de
Tue Dec 16 10:47:08 CET 2008


On Montag, 15. Dezember 2008, Stjepan Gros wrote:
> On Sun, Dec 14, 2008 at 9:13 PM, Jan-Oliver Wagner
> >> 3. What are the rules/recommendations for logging. As I saw,
> >> sometimes, printf is used, then fprintf, occasionally perror and
> >> finally log_* functions.
> >
> > I think we do not have defined rules yet.
> 
> Well, it seems like good oportunity for another CR? :)

indeed :-)
 
> >> 4. Why in plugutils there is a function "plug_get_oid" that only calls
> >> "_plug_get_oid"? Is there something planned in the future?
> >
> > I guess it is just there because the other methods (e.g. get_cve_id)
> > followed the same scheme. Perhaps yet another place to reduce code base.
> 
> This one is also fairly easy to change.

be careful. Sometimes the interdependencies in the code are far
more complex than expected (and far more complex than necessary).

Best

	Jan

-- 
Dr. Jan-Oliver Wagner | ++49-541-335 08 30  |  http://www.intevation.de/
Intevation GmbH, Neuer Graben 17, 49074 Osnabrück | AG Osnabrück, HR B 18998
Geschäftsführer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner


More information about the Openvas-devel mailing list