[Openvas-devel] Few questions about the code...
sgros.ml at gmail.com
Fri Dec 19 09:23:34 CET 2008
On Mon, Dec 15, 2008 at 10:39 PM, Jan-Oliver Wagner
<jan-oliver.wagner at intevation.de> wrote:
> On Monday 15 December 2008 08:30:48 Stjepan Gros wrote:
>> On Sun, Dec 14, 2008 at 9:13 PM, Jan-Oliver Wagner
>> <jan-oliver.wagner at intevation.de> wrote:
>> > On Sunday 14 December 2008 10:52:27 Stjepan Gros wrote:
>> >> 1. Who/where/when and why sets and uses ENABLE_PLUGIN_SERVER. I
>> >> grep'ed through the code and it's only used, not defined anywere!?
>> >> 2. The consequence of 1 is that "cache_dir" is never used (it's in
>> >> plugins directory, .bin subdirectory) and that cache I'm talking about
>> >> in CR is differently set.
>> > I think you spotted yet another portion of code that is unused.
>> > I found no place where the "Plugin Server" is enabled or even used.
>> > I also fail to understand the code (badly documented) nor can I
>> > imagine any reason why a "plugin server" should make sense.
>> > Does anyone else have an idea about this feature?
>> If no one has argument to leave this code in, I can generate a patch
>> to remove it. This should be fairly easy to do.
> I digged into this further and started to remove it.
> It is not so easy as thought initially.
> Re-inventing the wheel 3 times in a row sometimes characterizes
> the code base ;-)
Will you commit that soon? As I said, the cache_dir variable is
misleading and pointless and thus I'm going to reuse it to modify
behavior of openvas. Now, either you have to commit this before I
start coding, or I'll do it as a part of a first patch.
More information about the Openvas-devel