[Openvas-devel] [Openvas-commits] r914 - in trunk/openvas-plugins: . scripts

[Thomas Reinke]

Carsten Koch-Mauthe wrote:

> I've made also some additional changes to the script for recognizing SuSE 
> Distros. I've found that SuSE is named openSUSE since 10.2 and so the script 
> did not found actual versions. I have removed all one by one checks for the 
> Suse versions and added a  global check. The result is of course the same and 
> this change should not break any dependencies. 
> The first changed rows are only cosmetics, removed some trailing whitespace...
> If this change is ok, please let me know.  Then i will commit it.


Not sure I understood 'ver[max_index(ver)] = " ";'
If ver is null, this statement is meaningless, and
if it is defined, will always be '2', which is never used.

You probably should bracket everying in a
     if(!isnull(ver)) {
     }
after the eregmatch.

Thomas