[Openvas-devel] Certificate error after scanning a host

[Joey Schulze]

Moin,

for some days I see "report_save() couldn't save the certificate information"
after a scan.  This change is caused by the need to store the certificate and
the possibility to display certificate information.

However, context->signer_fp_certificates == NULL is considered an error
and thus routines fail, resulting in this error message.

Is this really the expected behaviour?

The problem is that (a) signer_fp_certificates is NULL and (b) that
openvas_certificate_file_write is called unconditionally in report.c
(report_save).

The attached patch fixes this.  Please let me know if I should commit it.

Regards,

	Joey

-- 
A mathematician is a machine for converting coffee into theorems.   Paul Erdös

Please always Cc to me when replying to me on the lists.
-------------- next part --------------
Index: nessus/report.c
===================================================================
--- nessus/report.c	(revision 1839)
+++ nessus/report.c	(working copy)
@@ -197,8 +198,8 @@
 
   /* Save the certificate information (as of now) to 
      report_dir/certificate file */
-  gboolean success = openvas_certificate_file_write(context, report_get_certificates_filename(report_context));
-  if(success == FALSE)
+  if (context->signer_fp_certificates != NULL &&
+      openvas_certificate_file_write(context, report_get_certificates_filename(report_context)) == FALSE)
     {
     show_error(_("report_save() couldn't save the certificate information"));
     return;