> Status: In discusssion. > -Votes: +7, in progress > +Votes: +7, in progress >
> >> -To establish standard script families (script_family) usage for the OpenVAS NVT's. > +To establish standard script families (script_family) usage for the OpenVAS NVTs. I think "NVT's" is technically correct, because NVT is an acronym. From felix.wolfsteller at intevation.de Fri Dec 11 08:17:03 2009 From: felix.wolfsteller at intevation.de (Felix Wolfsteller) Date: Fri, 11 Dec 2009 08:17:03 +0100 Subject: [Openvas-devel] nitpicky preference on script formatting In-Reply-To: <4B201EB8.7060401@securityspace.com> References: <4B201EB8.7060401@securityspace.com> Message-ID: <200912110817.03453.felix.wolfsteller@intevation.de> On Wednesday 09 December 2009 23:03:36 Thomas Reinke wrote: > We're noticing a bunch of scripts recently coming in > that have description fields formatted with leading > spaces on every line. > > That's probably something that should be avoided. > While we're not impacted, the code makes it clear > that the leading spaces are being done to adhere > to code formatting, as opposed to any consideration > that it can impact user presentation formatting. > > An example is gb_cutenews_n_utf8cutenews_mult_vuln.nasl > > Just my $0.02 worth. > > Thomas I am happy that you brought this issue up (as i am picky, too). Maybe the nasl developers should agree on some style and conventions and write an appropriate section in the compendium. Also, many descriptions start with newlines like the auto-generated ones: desc = " The remote host is missing an update to wireshark announced via advisory DSA 1942-1...." If code readability is so important (I would say it is) I would suggest to use the string function in both cases (or maybe the "+" operator would do the job, too): desc = string ("Some text, ", "continues on the next line, " "and goes on without looking too weird to me."); If the "+" operator would work (untested): desc = "Some text, " // to be decided where to put the plus-operator + "continues on the next line, " + "and so on"; -- felix > _______________________________________________ > Openvas-devel mailing list > Openvas-devel at wald.intevation.org > http://lists.wald.intevation.org/mailman/listinfo/openvas-devel -- Felix Wolfsteller | ++49 541 335083-783 | http://www.intevation.de/ PGP Key: 39DE0100 Intevation GmbH, Neuer Graben 17, 49074 Osnabr?ck | AG Osnabr?ck, HR B 18998 Gesch?ftsf?hrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner From lists at securityspace.com Fri Dec 11 13:48:49 2009 From: lists at securityspace.com (Thomas Reinke) Date: Fri, 11 Dec 2009 07:48:49 -0500 Subject: [Openvas-devel] nitpicky preference on script formatting In-Reply-To: <200912110817.03453.felix.wolfsteller@intevation.de> References: <4B201EB8.7060401@securityspace.com> <200912110817.03453.felix.wolfsteller@intevation.de> Message-ID: <4B223FB1.3090205@securityspace.com> > Also, many descriptions start with newlines like the auto-generated ones: > desc = " > The remote host is missing an update to wireshark > announced via advisory DSA 1942-1...." Fixed. > > If code readability is so important (I would say it is) I would suggest to use Ok...I'll bite.. As per original email, I don't care so much about how the code looks, but whether or not it screws up the formatting in reports the customer gets. From felix.wolfsteller at intevation.de Fri Dec 11 14:12:25 2009 From: felix.wolfsteller at intevation.de (Felix Wolfsteller) Date: Fri, 11 Dec 2009 14:12:25 +0100 Subject: [Openvas-devel] nitpicky preference on script formatting In-Reply-To: <4B223FB1.3090205@securityspace.com> References: <4B201EB8.7060401@securityspace.com> <200912110817.03453.felix.wolfsteller@intevation.de> <4B223FB1.3090205@securityspace.com> Message-ID: <200912111412.25319.felix.wolfsteller@intevation.de> On Friday 11 December 2009 13:48:49 you wrote: > > Also, many descriptions start with newlines like the auto-generated ones: > > desc = " > > The remote host is missing an update to wireshark > > announced via advisory DSA 1942-1...." > > Fixed. > > > If code readability is so important (I would say it is) I would suggest > > to use > > Ok...I'll bite.. > > As per original email, I don't care so much about how the code looks, > but whether or not it screws up the formatting in reports the customer > gets. You forgot to bite ;) The newlines at the beginning of the descriptions (sometimes one, sometimes two) jumped at me when looking at reports, not at code. It wasnt meant to aim at your scripts only. I believe they are all over the place. -- felix -- Felix Wolfsteller | ++49 541 335083-783 | http://www.intevation.de/ PGP Key: 39DE0100 Intevation GmbH, Neuer Graben 17, 49074 Osnabr?ck | AG Osnabr?ck, HR B 18998 Gesch?ftsf?hrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner From lists at securityspace.com Fri Dec 11 14:21:12 2009 From: lists at securityspace.com (Thomas Reinke) Date: Fri, 11 Dec 2009 08:21:12 -0500 Subject: [Openvas-devel] nitpicky preference on script formatting In-Reply-To: <200912111412.25319.felix.wolfsteller@intevation.de> References: <4B201EB8.7060401@securityspace.com> <200912110817.03453.felix.wolfsteller@intevation.de> <4B223FB1.3090205@securityspace.com> <200912111412.25319.felix.wolfsteller@intevation.de> Message-ID: <4B224748.3090203@securityspace.com> Felix Wolfsteller wrote: > On Friday 11 December 2009 13:48:49 you wrote: >>> Also, many descriptions start with newlines like the auto-generated ones: >>> desc = " >>> The remote host is missing an update to wireshark >>> announced via advisory DSA 1942-1...." >> Fixed. >> >>> If code readability is so important (I would say it is) I would suggest >>> to use >> Ok...I'll bite.. >> >> As per original email, I don't care so much about how the code looks, >> but whether or not it screws up the formatting in reports the customer >> gets. > > You forgot to bite ;) > > The newlines at the beginning of the descriptions (sometimes one, sometimes > two) jumped at me when looking at reports, not at code. It wasnt meant to aim > at your scripts only. I believe they are all over the place. Yeah - that shouldn't have been like that. And since you already know how I like hypocrisy, that's why I fixed our script generators and the scripts that were already generated to get rid of the leading newlines. Thomas From Jan-Oliver.Wagner at greenbone.net Tue Dec 15 13:26:40 2009 From: Jan-Oliver.Wagner at greenbone.net (Jan-Oliver Wagner) Date: Tue, 15 Dec 2009 13:26:40 +0100 Subject: [Openvas-devel] Bug tracker cleanup? Message-ID: <200912151326.46219.Jan-Oliver.Wagner@greenbone.net> Hi, I do see several "open" entries in the bug tracker that actually are reported as fixed. Geoff, can you go through them and close where issue is solved? Any other helping hand is welcome as well. Best Jan -- Dr. Jan-Oliver Wagner | ++49-541-335084-0 | http://www.greenbone.net/ Greenbone Networks GmbH, Neuer Graben 17, 49074 Osnabr?ck | AG Osnabr?ck, HR B 202460 Gesch?ftsf?hrer: Lukas Grunwald, Dr. Jan-Oliver Wagner From geoff at galitz.org Tue Dec 15 13:29:21 2009 From: geoff at galitz.org (Geoff Galitz) Date: Tue, 15 Dec 2009 13:29:21 +0100 Subject: [Openvas-devel] Bug tracker cleanup? In-Reply-To: <200912151326.46219.Jan-Oliver.Wagner@greenbone.net> References: <200912151326.46219.Jan-Oliver.Wagner@greenbone.net> Message-ID: <06C862B4EBEE4BB1A32E541688F79352@geoffPC> Sure thing. I'll get to this as soon as I can. Sorry for any delays, but things have been real busy over here (what recession?). Feel free to point out anything that needs updating in particular. I hope to get back to doing some more documentation, too. -geoff --------------------------------- Geoff Galitz Blankenheim NRW, Germany http://www.galitz.org/ http://german-way.com/blog/ > -----Original Message----- > From: openvas-devel-bounces at wald.intevation.org [mailto:openvas-devel- > bounces at wald.intevation.org] On Behalf Of Jan-Oliver Wagner > Sent: Dienstag, 15. Dezember 2009 13:27 > To: OpenVAS Development List > Subject: [Openvas-devel] Bug tracker cleanup? > > Hi, > > I do see several "open" entries in the bug tracker that actually are > reported > as fixed. Geoff, can you go through them and close where issue is solved? > Any other helping hand is welcome as well. > > Best > > Jan > > -- > Dr. Jan-Oliver Wagner | ++49-541-335084-0 | http://www.greenbone.net/ > Greenbone Networks GmbH, Neuer Graben 17, 49074 Osnabr?ck | AG Osnabr?ck, > HR B 202460 > Gesch?ftsf?hrer: Lukas Grunwald, Dr. Jan-Oliver Wagner > _______________________________________________ > Openvas-devel mailing list > Openvas-devel at wald.intevation.org > http://lists.wald.intevation.org/mailman/listinfo/openvas-devel From matthew.mundell at intevation.de Tue Dec 15 20:20:19 2009 From: matthew.mundell at intevation.de (Matthew Mundell) Date: 15 Dec 2009 19:20:19 GMT Subject: [Openvas-devel] nitpicky preference on script formatting In-Reply-To: Message of Fri, 11 Dec 2009 08:17:03 +0100. <200912110817.03453.felix.wolfsteller@intevation.de> Message-ID: <20091215192358.807CDDECE2@mail.ukfsn.org> > > We're noticing a bunch of scripts recently coming in > > that have description fields formatted with leading > > spaces on every line. > I am happy that you brought this issue up (as i am picky, too). > Maybe the nasl developers should agree on some style and conventions and write > an appropriate section in the compendium. It'd also be helpful if the descriptions were at most 80 characters wide, so that we could safely display them in verbatim contexts. -- Intevation GmbH, Neuer Graben 17, 49074 Osnabr?ck | AG Osnabr?ck, HR B 18998 Gesch?ftsf?hrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner From matthew.mundell at intevation.de Tue Dec 15 21:52:28 2009 From: matthew.mundell at intevation.de (Matthew Mundell) Date: 15 Dec 2009 20:52:28 GMT Subject: [Openvas-devel] [Openvas-commits] r6081 - in trunk/openvas-manager: . src In-Reply-To: Message of Mon, 7 Dec 2009 16:17:14 +0100 (CET). <20091207151714.7A2C6861F2F7@pyrosoma.intevation.org> Message-ID: <20091215205607.4CD0FDECA1@mail.ukfsn.org> > Log: > Fixed up some free()s > --- trunk/openvas-manager/src/omp.c 2009-12-07 14:20:51 UTC (rev 6080) > +++ trunk/openvas-manager/src/omp.c 2009-12-07 15:17:12 UTC (rev 6081) > @@ -5414,7 +5414,7 @@ > if (hosts == NULL) > { > request_delete_task (¤t_client_task); > - g_free (description); > + free (description); > free (tsk_uuid); > SEND_TO_CLIENT_OR_FAIL > (XML_ERROR_SYNTAX > @@ -5424,7 +5424,7 @@ > set_client_state (CLIENT_AUTHENTIC); > break; > } > - g_free (description); > + free (description); > > target_name = g_strdup_printf ("Imported target for task %s", > tsk_uuid); > @@ -5947,7 +5947,7 @@ > g_free (response); > g_free (name); > g_free (description64); > - g_free (tsk_uuid); > + free (tsk_uuid); Thanks Tim, these three are actually allocated by GLib. The Manager mixes C and GLib allocations extensively, mostly because I've been reluctant to put GLib in any interface that could become external. I think the mixing is safe for now. I'd like to clean through it all at some point. -- Intevation GmbH, Neuer Graben 17, 49074 Osnabr?ck | AG Osnabr?ck, HR B 18998 Gesch?ftsf?hrer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner From openvas-bugs at wald.intevation.org Thu Dec 17 12:17:53 2009 From: openvas-bugs at wald.intevation.org (openvas-bugs@wald.intevation.org) Date: Thu, 17 Dec 2009 12:17:53 +0100 (CET) Subject: [Openvas-devel] =?utf-8?q?=5Bopenvas-Bugs=5D=5B1224=5D_Segfault_s?= =?utf-8?q?tarting_openvasd_freeBSD?= Message-ID: <20091217111753.4AF5A861F2DB@pyrosoma.intevation.org> Bugs item #1224, was opened at 17-12-2009 11:17 Status: Open Priority: 3 Submitted By: Guilherme Martini (gmartini) Assigned to: Nobody (None) Summary: Segfault starting openvasd freeBSD Architecture: 32 Bit Resolution: None Severity: None Version: None Component: openvas-server Operating System: FreeBSD Product: OpenVAS Hardware: None URL: Initial Comment: I have installed openvas server in a FreeBSD and it works fine, but after I have run openvas-nvt-sync I can't start openvasd anymore. When I try to do it I have the fallowing error. Loading the OpenVAS plugins...[740]() gpgme_new failed: User defined source 1/Not operational Segmentation fault (core dumped) Someone have any ideia how I can resolve it? ---------------------------------------------------------------------- You can respond by visiting: http://wald.intevation.org/tracker/?func=detail&atid=220&aid=1224&group_id=29 From Jan-Oliver.Wagner at greenbone.net Mon Dec 21 10:51:39 2009 From: Jan-Oliver.Wagner at greenbone.net (Jan-Oliver Wagner) Date: Mon, 21 Dec 2009 10:51:39 +0100 Subject: [Openvas-devel] Working on website relaunch Message-ID: <200912211051.49894.Jan-Oliver.Wagner@greenbone.net> Hi, now that 3.0 is out it is really time to improve the OpenVAS website in terms of design and structure. This task was on the table since the developer conference this summer. Hower, no one was able to invest time into this (no compaints here, I know it a boring task compared to hacking OpenVAS/NVTs!), so I like to pick up this lost end now. Greenbone has some resources and will make a relaunch (no CMS, just the same technology as currently used but with nicer design with a layout similar to Greenbone's homepage -- that's the most cost efficient way). Anyone who likes to commit his/her time into this relaunch, please let me know. Best Jan -- Dr. Jan-Oliver Wagner | ++49-541-335084-0 | http://www.greenbone.net/ Greenbone Networks GmbH, Neuer Graben 17, 49074 Osnabr?ck | AG Osnabr?ck, HR B 202460 Gesch?ftsf?hrer: Lukas Grunwald, Dr. Jan-Oliver Wagner From openvas-bugs at wald.intevation.org Tue Dec 22 16:55:02 2009 From: openvas-bugs at wald.intevation.org (openvas-bugs@wald.intevation.org) Date: Tue, 22 Dec 2009 16:55:02 +0100 (CET) Subject: [Openvas-devel] =?utf-8?q?=5Bopenvas-Bugs=5D=5B1227=5D_nothing_pr?= =?utf-8?q?ovides_libadmin=2Eso_needed_by_openvas-administrator?= Message-ID: <20091222155502.5BE7D861F2C9@pyrosoma.intevation.org> Bugs item #1227, was opened at 22/12/2009 15:55 Status: Open Priority: 3 Submitted By: Angelo Compagnucci (angeloc) Assigned to: Nobody (None) Summary: nothing provides libadmin.so needed by openvas-administrator Architecture: None Resolution: None Severity: normal Version: v3.0.0 Component: openvas-administrator Operating System: Linux Product: OpenVAS Hardware: None URL: Initial Comment: I'm using OpenVAS UNSTABLE BuildService repository for OpenSUSE 11.1 and I receive this error installing Openvas-administrator. This is a first installation and I've only this repos configured on my installation.