[Openvas-devel] Hamonized Logging (CR #29)

[Lmwangi]

Hi Jan/All,
 Seeing this message today :( Must be the weather ... :) It's raining
at last. Please see my responses inline

On Tue, May 5, 2009 at 9:46 AM, Jan-Oliver Wagner
<jan-oliver.wagner at intevation.de> wrote:
> On Tuesday 28 April 2009 15:25:21 Laban Mwangi wrote:
>> On Tue, 2009-04-28 at 09:03 +0200, Jan-Oliver Wagner wrote:
>> > * we should hasve "log_domain" a configuration option in openvasd.conf
>> >    rather than a compiletime option
>> > * We should us variables for g_log like "log_domain_nasl",
>> > "log_domain_otp",
>> >    "log_domain_ssl", etc. In normal case all point to the same
>> > log_domain, but then it is easier to set a focus on a specific topic in
>> > the future.
>>
>> OK no problem :)
>>
>> We then have an openvasd logging configuration file that defines:
>>   - log domain
>>   - log prepend string
>>   - log file
>>   - log level threshold
>
> hm, I was more envisoning that with the log domain the other params
> are fixed. "log_domain_otp" has its own file, level and prepend string.
> By default all should go into the same file with the same level and its
> own prepend strings.
>
Hmm. Still not getting you. Please see the attached patch for a sample
implementation
>> These parameters can be specified in gkeyfile groups.
>>...
>
>> What we can then do is handle the message routing within the logger_func
>> based on the message log domain.
> Can you add the results of our discuss to the Change Request and then
> call for a vote?
I want to merge the feedback from the second patch with this mail
before I enhance the CR.
>
Here's a list of the changed files.
$svn status |grep -v ?
M      openvasd/openvasd.c
M      openvasd/Makefile
M      configure
M      configure.in
M      openvas.tmpl.in
A      openvas_logging.conf
M      Makefile

Patch comments
 - Logic to copy openvas_logging.conf only if it does not exist (A
test -f should work)
 - May need to move the functions added to openvasd.c to log.c and log.h
 - You may need to edit libnasl to call glib's logging messages
 - Ideas for the logging influenced by the midgard project

Regards,
Laban
-------------- next part --------------
A non-text attachment was scrubbed...
Name: logging_rev2.patch
Type: text/x-patch
Size: 24256 bytes
Desc: not available
Url : http://lists.wald.intevation.org/pipermail/openvas-devel/attachments/20090507/c61c852b/logging_rev2-0001.bin