[Openvas-devel] [Openvas-commits] r5228 - in trunk/openvas-manager: . src src/tests

Matthew Mundell matthew.mundell at intevation.de
Fri Sep 25 11:13:56 CEST 2009


> ===================================================================
> --- trunk/openvas-manager/src/manage.h	2009-09-25 07:32:08 UTC (rev 5227)
> +++ trunk/openvas-manager/src/manage.h	2009-09-25 07:45:23 UTC (rev 5228)
> @@ -30,8 +30,8 @@
>  #include <glib.h>
>  #include <ossp/uuid.h>
>
> -#include <openvas/certificate.h>
> -#include <openvas/nvti.h>
> +#include <openvas/base/certificate.h> /* for certificate_t */
> +#include <openvas/base/nvti.h> /* for nvti_t */

Please can we refrain from doing this.  It adds maintenance with little
gain.  It makes the include block text-heavy and messy, and it's hard to do
consistently.  There's little need for it in these cases.  For nvti, for
example, the word nvti only occurs twice in manage.h, so it's easy to see
the reason that the include is present.  nvti.h exports a small interface
anyway, so it would be pretty obvious even in a large file like manage.c.


More information about the Openvas-devel mailing list