[Openvas-devel] [Openvas-commits] r6923 - in trunk/openvas-libraries: . misc

[Matthew Mundell]

> Author: felix
> Date: 2010-03-08 13:55:59 +0100 (Mon, 08 Mar 2010)
> New Revision: 6923
>
> Added:
>    trunk/openvas-libraries/misc/ldap_auth.c
>    trunk/openvas-libraries/misc/ldap_auth.h
> Modified:
>    trunk/openvas-libraries/ChangeLog
> Log:
> Initial ldap_auth module to enable future ldap authentication support.
>
> * misc/ldap_auth.c, misc/ldap_auth.h: Added new files.


> Added: trunk/openvas-libraries/misc/ldap_auth.c
> ===================================================================
> --- trunk/openvas-libraries/misc/ldap_auth.c	2010-03-08 11:57:34 UTC (rev 6922)
> +++ trunk/openvas-libraries/misc/ldap_auth.c	2010-03-08 12:55:59 UTC (rev 6923)
> @@ -0,0 +1,187 @@
> +/* OpenVAS Manager

Libraries!

> +#include "ldap_auth.h"
> +
> +#include <stdio.h>
> +
> +#include "glib.h"

#include <stdio.h>
#include <glib.h>
?

> +ldap_auth_info_t
> +ldap_auth_info_new (const gchar* _auth_dn_before_user,
> +                    const gchar* _auth_dn_after_user,
> +                    const gchar* _ldap_host)
> +{

Why the underscores suddenly, Felix?

> Added: trunk/openvas-libraries/misc/ldap_auth.h
> ===================================================================
> --- trunk/openvas-libraries/misc/ldap_auth.h	2010-03-08 11:57:34 UTC (rev 6922)
> +++ trunk/openvas-libraries/misc/ldap_auth.h	2010-03-08 12:55:59 UTC (rev 6923)
> @@ -0,0 +1,72 @@
> +/* OpenVAS Manager

Libraries!

> +ldap_auth_info_t
> +ldap_auth_info_new (const gchar* _auth_dn_before_user,
> +                    const gchar* _auth_dn_after_user,
> +                    const gchar* _ldap_host);

	nvti_t *nvti_new (void);

	void nvti_free (nvti_t *);

I think we should aim for more consistency in our interfaces.
--
Intevation GmbH, Neuer Graben 17, 49074 Osnabrück | AG Osnabrück, HR B 18998
Geschäftsführer: Frank Koormann, Bernhard Reiter, Dr. Jan-Oliver Wagner