[Openvas-devel] Patch to drop 3500 lines of code

Tim Brown timb at openvas.org
Mon Oct 11 21:07:36 CEST 2010


On Monday 11 October 2010 16:49:57 Jan-Oliver Wagner wrote:
> Hi,
> 
> I prepared a patch that resolves the last occurance of the harglist/hlst
> implementation. Which counts about 3500 lines of code and is IMHO used for
> only
> a trivial task that I re-implemented with a simple hash method of glib.
> 
> I added also a (not so pretty) patch which I used to practically proove
> that the new implementation delivers the same results as the old
> implementation. It does for my test case.
> 
> Any concerns regarding this change?

Doesn't seem to cause any regressions as far as cppcheck and flawfinder can 
tell.  I'm going to build the patched version and run it under valgrind too 
(although your code looks fine).

Tim
-- 
Tim Brown
<mailto:timb at nth-dimension.org.uk>
<http://www.nth-dimension.org.uk/>

-- 
Tim Brown
<mailto:timb at openvas.org>
<http://www.openvas.org/>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.wald.intevation.org/pipermail/openvas-devel/attachments/20101011/9d22deec/attachment.pgp


More information about the Openvas-devel mailing list