[Openvas-distro] openvas-libraries: DESTDIR missing

[Javier Fernández-Sanguino Peña]

On Wed, Apr 16, 2008 at 06:51:04AM +0100, Tim Brown wrote:
> On Tuesday 15 April 2008 14:09:39 Jan-Oliver Wagner wrote:
> > Hi,
> >
> > I was just working on a RPM package for openvas-libraries and
> > stumbled across missing DESTDIR use in some Makefiles of
> > this module.
> >
> > Guess this will hurt the Debian packages as well. Tim?
> >
> > We use DESTDIR consistently only for openvas-client so far.
> > Should we patch all other modules to use it as well?
> 
> The Debian packaging scripts reset prefix during the make install like so:
> 
> $(MAKE) install prefix=$(tmp)/usr

This is not correct. The 'prefix' definition gets hardcoded in the built
binaries.

DESTDIR is needed, I do not understand why it was removed.

Please do not deviate from coding standards. For more information about
DESTDIR please see http://www.gnu.org/prep/standards/standards.html#DESTDIR

- prefix: is used to tell the binaries where they will be running
  (that's why it's defined in the configure)

- DESTDIR: is used to tell the install targets that they have to install in a
  non-standard location
  (that's why it is used in the Makefiles)

Regards

Javier
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.wald.intevation.org/pipermail/openvas-distro/attachments/20080416/296a4911/attachment.pgp