[Openvas-plugins] NASL-Skript for reporting all open ports not reported elsewhere

[Michael Meyer]

Hello Hartmut,

*** Hartmut Goebel <h.goebel at goebel-consult.de> wrote:

> The Script is meant to run *after* all other Service detectors (which
> are reporting results). But I doubt, I did this right.

[...]

>    script_dependencies("nmap.nasl", "amap.nasl",
>                        "find_service.nes",
> 		       "find_service1.nasl", "find_service2.nasl",
> 		       "openvas_tcp_scanner.nes",
> 		       "synscan.nes",
> 		       "pnscan.nasl", "portbunny.nasl", 
> 		       "portscan-strobe.nasl", "ike-scan.nasl"
>    );

This means nmap.nasl, amap.nasl, synscan.nes, pnscan.nasl,... are always
running (If "Enable Dependencies" is TRUE) even if one has decided not 
to run them.

One possibility would be to change "script_category()" from
"ACT_GATHER_INFO" to "ACT_END" and remove all dependencies. Then
your plugin will run at the end of the scan and you can be sure that
all other service detectors are running before your script.

Another possibility would be to add a preference for this Plugin.

"script_add_preference(name:"Report all open Ports", type:"checkbox", value:"no")".

So everyone can decide whether he wants this report or not. Please set
the default in any case to "no".

I would prefer if you use both. Set "script_category()" to
"ACT_END" (including removing all the dependencies) *and* add a
Preference.

Just my two cents.

Micha

-- 
Michael Meyer                                         OpenPGP Key: 76E050B9
http://www.intevation.de
Intevation GmbH, Neuer Graben 17, 49074 Osnabrück; AG Osnabrück, HR B 18998
Geschäftsführer:   Frank Koormann,  Bernhard Reiter,  Dr. Jan-Oliver Wagner