<br><br><div class="gmail_quote">On Wed, Sep 22, 2010 at 4:17 PM, Bernhard Herzog <span dir="ltr"><<a href="mailto:bh@intevation.de">bh@intevation.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">Igor Novikov <<a href="mailto:igor.e.novikov@gmail.com">igor.e.novikov@gmail.com</a>> writes:<br>
<br>
>> > 2.Source code is separated from other files<br>
>><br>
>> A good goal in principle, do you have a list of specific changes<br>
>> you are proposing?<br>
>><br>
>><br>
> 1. Skencil/, Resources/, Script/ and Plugins/ are moved into src/ folder<br>
> 2. Lib/ folder is eliminated and all native modules are relocated into<br>
> Skencil/Modules/ folder<br>
> 3. Pixmaps/ is moved from Skencil/ into Resources/<br>
<br>
</div>Isn't this a bit much of change for just a minor version number increase<br>
(0.6.17 to 0.6.18)? The changes are not wrong, they just seem to be a<br>
bit much.<br></blockquote><div><br>As we have agreed before revitalized version will be 1.0. I have incremented<br>application version as 1.0alpha<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">
> 4. Root "skencil" package is introduced<br>
<br>
</div>What will that mean for Skencil users? Will their startup-scripts and<br>
third-party scripts and plugins still work?<br></blockquote><div><br>Internal application structure is not changed. So all scripts and plugins<br>will be workable.<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im"><br>
> 5. All native extensions source code is relocated in extensions/ folder<br>
><br>
> Also I have moved temporary old description files from root folder into<br>
> old_files/<br>
> I have left only README file because it's required for distutils. The files<br>
> should be<br>
> refactored because some of them are have no sense. For example BUGS is good<br>
> for<br>
> small console utilities but not for large application. Known bugs should be<br>
> in project<br>
> bug tracker and there is no sense exposing incomplete bug list in BUGS file.<br>
> And<br>
> the same for other files. I think Skencil project should has a more flexible<br>
><br>
> infrastructure on project web site to provide detailed info for users.<br>
<br>
</div>Likewise perhaps a bit much of a change, although less critical than<br>
moving the code around. However, updating the content and removing<br>
obsolete files would of course be fine.<br>
<div class="im"><br>
>> > 3.Proposed source code structure allows launching Skencil using SVN copy<br>
>><br>
>> Directly? Isn't this possible already?<br>
>><br>
><br>
> Yes, it's possible now. Source code structure is equal to working<br>
> application. On my computer<br>
> src/ folder is linked as a 'skencil' in $PYTHON_HOME/dist-packages/ and<br>
> skencil start script is placed<br>
> into /usr/bin That's all needed for running SVN copy.<br>
<br>
</div>I think the code should be organized so that even that is not<br>
necessary. After the necessary build steps -- which only create files<br>
in the working copy -- it should be possible to start Skencil from that<br>
working copy.<br></blockquote><div><br>And this is possible already. I have added skencil-launcher.py to run <br>application on development stage. For native extensions I will add <br>custom 'build&copy' command to automate native extensions rebuild.<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im"><br>
> And of course compiled<br>
> native extensions<br>
> are copied into src/Sketch/Modules/ By this way we have accelerated sK1<br>
> development skipping<br>
> application build after each code modification.<br>
<br>
</div>I'm not sure I understand how this accelerates things. The only files<br>
that have to be recompiled are the C extensions and those are not<br>
modified that often and they won't be compiled automatically either with<br>
your proposed changes.<br></blockquote><div><br>We use Eclipse+PyDev+Subclipse for development. Such project structure<br>allows implementing changes, running application and committing from IDE<br>without using additional tools. It really saves a lot of time.<br>
<br>I have committed all changes step-by-step and rev.721 can be compiled and<br>installed for testing (or running from SVN copy). On Ubuntu 10.04 this build<br>works fine and application can be run without patches.<br><br>
Next step will be elimination of mixed indents. As have been mentioned before<br>default indent will be 4 spaces. <br clear="all"></div></div><br>-- <br>Regards,<br><br>Igor Novikov<br>sK1 Project<br><a href="http://sk1project.org" target="_blank">http://sk1project.org</a><br>
<br><br>