[Dive4elements-commits] [PATCH 6 of 6] Converting from list to array doesn't make sence here

Wald Commits scm-commit at wald.intevation.org
Fri Nov 2 15:57:15 CET 2012


# HG changeset patch
# User Björn Ricks <bjoern.ricks at intevation.de>
# Date 1351868151 -3600
# Node ID 80f5d1f2d4fd8b942021d1d7d14e994a82e2efed
# Parent  19754e5227c839e4363d594db9277a09400b1448
Converting from list to array doesn't make sence here

diff -r 19754e5227c8 -r 80f5d1f2d4fd flys-client/src/main/java/de/intevation/flys/client/client/ui/DatacageWindow.java
--- a/flys-client/src/main/java/de/intevation/flys/client/client/ui/DatacageWindow.java	Fri Nov 02 15:54:41 2012 +0100
+++ b/flys-client/src/main/java/de/intevation/flys/client/client/ui/DatacageWindow.java	Fri Nov 02 15:55:51 2012 +0100
@@ -94,7 +94,7 @@
     public void toLoad(ToLoad toLoad) {
         destroy();
         List<Recommendation> recs = toLoad.toRecommendations();
-        loadArtifacts(recs.toArray(new Recommendation[recs.size()]));
+        loadArtifacts(recs);
     }
 
 
@@ -102,7 +102,7 @@
     public void onDoubleClick(ToLoad toLoad) {
         destroy();
         List<Recommendation> recs = toLoad.toRecommendations();
-        loadArtifacts(recs.toArray(new Recommendation[recs.size()]));
+        loadArtifacts(recs);
     }
 
 
@@ -157,14 +157,14 @@
     }
 
 
-    protected void loadArtifacts(Recommendation[] recommendations) {
+    protected void loadArtifacts(List<Recommendation> recommendations) {
         Config cfg = Config.getInstance();
 
         final Collection collection     = view.getCollection();
         final Artifact   masterArtifact = view.getArtifact();
         final String     locale         = cfg.getLocale();
 
-        this.inProgress = recommendations.length;
+        this.inProgress = recommendations.size();
 
         for (final Recommendation recommendation: recommendations) {
             // XXX: UGLY! If no reference artifact given use uuid of


More information about the Dive4elements-commits mailing list