[Dive4elements-commits] [PATCH 2 of 2] Use static variable for login page name in LoginServlet

Wald Commits scm-commit at wald.intevation.org
Thu Nov 8 10:47:34 CET 2012


# HG changeset patch
# User Björn Ricks <bjoern.ricks at intevation.de>
# Date 1352368044 -3600
# Node ID e2d8f344491e475982df54de851d1f034bfc5a29
# Parent  0074c113bb957049f75977f2528600bb99364dc0
Use static variable for login page name in LoginServlet

diff -r 0074c113bb95 -r e2d8f344491e flys-client/src/main/java/de/intevation/flys/client/server/LoginServlet.java
--- a/flys-client/src/main/java/de/intevation/flys/client/server/LoginServlet.java	Thu Nov 08 10:29:09 2012 +0100
+++ b/flys-client/src/main/java/de/intevation/flys/client/server/LoginServlet.java	Thu Nov 08 10:47:24 2012 +0100
@@ -21,11 +21,13 @@
 public class LoginServlet extends HttpServlet {
 
     private static Logger logger = Logger.getLogger(LoginServlet.class);
+
     private static final String FLYS_PAGE = "FLYS.html";
+    private static final String LOGIN_PAGE = "login.jsp";
 
     private void redirectFailure(HttpServletResponse resp, String path)
         throws IOException {
-        resp.sendRedirect(path + "/login.jsp");
+        resp.sendRedirect(path + "/" + LOGIN_PAGE);
     }
 
     private void redirectFailure(HttpServletResponse resp, String path,
@@ -35,7 +37,7 @@
 
     private void redirectFailure(HttpServletResponse resp, String path,
             String message) throws IOException {
-        resp.sendRedirect(path + "/login.jsp?error=" + message);
+        resp.sendRedirect(path + "/" + LOGIN_PAGE + "?error=" + message);
     }
 
     private void redirectSuccess(HttpServletResponse resp, String path,
@@ -110,6 +112,7 @@
         ServletContext sc = this.getServletContext();
         Features features = (Features)sc.getAttribute(Features.CONTEXT_ATTRIBUTE);
         String auth = sc.getInitParameter("authentication");
-        return AuthenticationFactory.getInstance(auth).auth(username, password, encoding, features);
+        return AuthenticationFactory.getInstance(auth).auth(username, password,
+                encoding, features);
     }
 }


More information about the Dive4elements-commits mailing list