[Dive4elements-commits] [PATCH] issue1259: fixing initial selected input helper tab. Believing that there is a bug in TabSet

Wald Commits scm-commit at wald.intevation.org
Tue Jun 25 08:52:26 CEST 2013


# HG changeset patch
# User Felix Wolfsteller <felix.wolfsteller at intevation.de>
# Date 1372143705 -7200
# Node ID c1b01cf2e91bd901b61f558fdf11aecf4e9fa882
# Parent  c74261e05a62388b818f642aad052a77ef99a077
issue1259: fixing initial selected input helper tab. Believing that there is a bug in TabSet.

diff -r c74261e05a62 -r c1b01cf2e91b gwt-client/src/main/java/org/dive4elements/river/client/client/ui/WQAdaptedInputPanel.java
--- a/gwt-client/src/main/java/org/dive4elements/river/client/client/ui/WQAdaptedInputPanel.java	Tue Jun 25 08:05:36 2013 +0200
+++ b/gwt-client/src/main/java/org/dive4elements/river/client/client/ui/WQAdaptedInputPanel.java	Tue Jun 25 09:01:45 2013 +0200
@@ -163,6 +163,13 @@
 
         initTableListeners();
 
+        // We actually want the first Q tab to be selected and all
+        // Q tabs to be enabled. I sense a bug in TabSet here, as
+        // the code in the W/Q radiogroup-changehandler behaves
+        // exactly vice versa (enabling Q, selecting tab 0).
+        enableWTabs();
+        tabs.selectTab(1);
+
         return layout;
     }
 
@@ -195,7 +202,7 @@
 
             tabs.addTab(wTab, i*2+0);
             tabs.addTab(qTab, i*2+1);
-            tabs.disableTab(i*2+1);
+            //tabs.disableTab(i*2+1);
         }
 
         // Defaults at "Q", first input field.


More information about the Dive4elements-commits mailing list