[PATCH 2 of 3] (issue1733) Remove weird and broken code (fixes tab selection)

Wald Commits scm-commit at wald.intevation.org
Mon Oct 27 14:37:21 CET 2014


# HG changeset patch
# User Andre Heinecke <andre.heinecke at intevation.de>
# Date 1414409902 -3600
# Node ID 4b315e5d2d4f6de88cfab53fdbc25b9a6f867b58
# Parent  75b84f139c1b5f210b3a18bc36856692bbbeccea
(issue1733) Remove weird and broken code (fixes tab selection)

    This code did not make any sense to me. Why should the tabs
    be removed and readded. Just selecting them works.

diff -r 75b84f139c1b -r 4b315e5d2d4f gwt-client/src/main/java/org/dive4elements/river/client/client/ui/LocationDistancePanel.java
--- a/gwt-client/src/main/java/org/dive4elements/river/client/client/ui/LocationDistancePanel.java	Mon Oct 27 12:32:04 2014 +0100
+++ b/gwt-client/src/main/java/org/dive4elements/river/client/client/ui/LocationDistancePanel.java	Mon Oct 27 12:38:22 2014 +0100
@@ -1191,16 +1191,6 @@
             filterRange.clear();
             filterResultCount.setValue("");
 
-            // Remove the tab containing the locationDistanceTable.
-            // The 'updateTab()' avoids the tab content to be destroyed.
-            inputTables.updateTab(0, null);
-            inputTables.removeTab(0);
-
-            // Create a new tab containing the locationTable
-            Tab t1 = new Tab (MESSAGES.locations());
-            t1.setPane(locationsTable);
-            inputTables.addTab(t1, 0);
-
             // Bring this tab to front.
             inputTables.selectTab(0);
         }
@@ -1211,16 +1201,6 @@
             filterRange.clear();
             filterResultCount.setValue("");
 
-            // Remove the tab containing the locationTable.
-            // The 'updateTab()' avoids the tab content to be destroyed.
-            inputTables.updateTab(0, null);
-            inputTables.removeTab(0);
-
-            // Create a new tab containing the locationDistanceTable.
-            Tab t1 = new Tab(MESSAGES.locations());
-            t1.setPane(locationDistanceTable);
-            inputTables.addTab(t1, 0);
-
             // Bring the distanceTable tab to front.
             inputTables.selectTab(1);
         }


More information about the Dive4Elements-commits mailing list