[PATCH] (issue1754) Only create new Recommendations

Wald Commits scm-commit at wald.intevation.org
Mon Apr 27 11:46:55 CEST 2015

# HG changeset patch
# User Andre Heinecke <andre.heinecke at intevation.de>
# Date 1430127931 -7200
# Node ID b5ac17a10d2291b4d482aa42f8ef660ec8ab5013
# Parent  b5cff23bf3083881f0ecaea3a854a405beb975eb
(issue1754) Only create new Recommendations

    I belive that this was the original intent of this function
    otherwise why create a list of newRecommendations at all if
    we always recreate all Recommendations again.

    With the side effect that old recommendations had no master
    artifact the created artifacts of already existing artifacts
    did not have enough information to live and were not shown
    in the client so this problem was hidden.

diff -r b5cff23bf308 -r b5ac17a10d22 gwt-client/src/main/java/org/dive4elements/river/client/client/ui/CollectionView.java
--- a/gwt-client/src/main/java/org/dive4elements/river/client/client/ui/CollectionView.java	Fri Apr 24 18:03:46 2015 +0200
+++ b/gwt-client/src/main/java/org/dive4elements/river/client/client/ui/CollectionView.java	Mon Apr 27 11:45:31 2015 +0200
@@ -736,7 +736,7 @@
-            recommendations,
+            newRecommendations.toArray(new Recommendation[0]),
             new AsyncCallback<Artifact[]>() {

More information about the Dive4Elements-commits mailing list