[PATCH 1 of 4] Backout 8709:71ae18553377 Regression risk too high

Wald Commits scm-commit at wald.intevation.org
Mon Apr 27 16:33:17 CEST 2015


# HG changeset patch
# User Andre Heinecke <andre.heinecke at intevation.de>
# Date 1430131704 -7200
# Node ID 68916dd6359bb233cd25a0c5b8ce4cc0a1f32956
# Parent  b5ac17a10d2291b4d482aa42f8ef660ec8ab5013
Backout 8709:71ae18553377 Regression risk too high.

diff -r b5ac17a10d22 -r 68916dd6359b gwt-client/src/main/java/org/dive4elements/river/client/client/ui/CollectionView.java
--- a/gwt-client/src/main/java/org/dive4elements/river/client/client/ui/CollectionView.java	Mon Apr 27 11:45:31 2015 +0200
+++ b/gwt-client/src/main/java/org/dive4elements/river/client/client/ui/CollectionView.java	Mon Apr 27 12:48:24 2015 +0200
@@ -721,17 +721,17 @@
         }
 
         for (final Recommendation recommendation: recommendations) {
+            if (collection.loadedRecommendation(recommendation)) {
+                continue;
+            }
+            newRecommendations.push(recommendation);
+
             // XXX: UGLY! If no reference artifact given use uuid of
             //      current artifact as reference.
             if (recommendation.getMasterArtifact() == null) {
                 recommendation.setMasterArtifact(masterArtifact.getUuid());
             }
 
-            if (collection.loadedRecommendation(recommendation)) {
-                GWT.log("Already loaded " +  recommendation.getDisplayName());
-                continue;
-            }
-            newRecommendations.push(recommendation);
         }
 
         loadArtifactService.loadMany(


More information about the Dive4Elements-commits mailing list