[PATCH 44 of 45] There seems to be no use case for not overriding these methods

Wald Commits scm-commit at wald.intevation.org
Tue Mar 10 17:06:12 CET 2015


# HG changeset patch
# User Tom Gottfried <tom at intevation.de>
# Date 1425641172 -3600
# Node ID c16d04f2c5bcb2f9223a618ec44129ee6fe5ab36
# Parent  5c53b7de04d96519f67bf99dc78ce9b28371a831
There seems to be no use case for not overriding these methods.

diff -r 5c53b7de04d9 -r c16d04f2c5bc artifacts/src/main/java/org/dive4elements/river/artifacts/services/AbstractChartService.java
--- a/artifacts/src/main/java/org/dive4elements/river/artifacts/services/AbstractChartService.java	Fri Mar 06 11:21:36 2015 +0100
+++ b/artifacts/src/main/java/org/dive4elements/river/artifacts/services/AbstractChartService.java	Fri Mar 06 12:26:12 2015 +0100
@@ -76,11 +76,9 @@
     protected abstract JFreeChart createChart(Document data,
         GlobalContext globalContext, CallMeta callMeta);
 
-    protected void init() {
-    };
+    protected abstract void init();
 
-    protected void finish() {
-    };
+    protected abstract void finish();
 
     @Override
     public Service.Output process(Document data, GlobalContext globalContext,


More information about the Dive4Elements-commits mailing list