[PATCH 1 of 3] Comment concerning a bug in current manual points editor

Wald Commits scm-commit at wald.intevation.org
Thu Jun 7 17:51:21 CEST 2018


# HG changeset patch
# User gernotbelger
# Date 1528299814 -7200
# Node ID 0f7364772dd1f3b5a6c7f39b2a64646b930e10ca
# Parent  8cc192731c7dc34020bcd1af767f7782ff785e05
Comment concerning a bug in current manual points editor

diff -r 8cc192731c7d -r 0f7364772dd1 gwt-client/src/main/java/org/dive4elements/river/client/client/ui/chart/ManualPointsEditor.java
--- a/gwt-client/src/main/java/org/dive4elements/river/client/client/ui/chart/ManualPointsEditor.java	Wed Jun 06 14:24:51 2018 +0200
+++ b/gwt-client/src/main/java/org/dive4elements/river/client/client/ui/chart/ManualPointsEditor.java	Wed Jun 06 17:43:34 2018 +0200
@@ -200,6 +200,9 @@
                         (StringProperty)pg.getPropertyByName("label");
                     xAxis = name.getValue();
                 }
+                // FIXME: this always selects the first axis not named 'X' regardless of on what axis the manual points sit.
+                // Actually we do not have the information about the manual points axis
+                // One solution might be to add that axis as extra info into the chart settings: but would be a very special case
                 else if (yAxis.equals("Y")) {
                     StringProperty name =
                         (StringProperty)pg.getPropertyByName("label");


More information about the Dive4Elements-commits mailing list