[PATCH 1 of 3] Do not silently eat exceptions!

Wald Commits scm-commit at wald.intevation.org
Wed Mar 28 14:35:08 CEST 2018


# HG changeset patch
# User gernotbelger
# Date 1522240460 -7200
# Node ID 175f113ed939f2556f480862f422279ce92314ab
# Parent  3c95b89da5ea0e7d7635d9a489b331feb03d1c14
Do not silently eat exceptions!

diff -r 3c95b89da5ea -r 175f113ed939 artifacts/src/main/java/org/dive4elements/river/artifacts/datacage/templating/Builder.java
--- a/artifacts/src/main/java/org/dive4elements/river/artifacts/datacage/templating/Builder.java	Fri Mar 23 17:53:59 2018 +0100
+++ b/artifacts/src/main/java/org/dive4elements/river/artifacts/datacage/templating/Builder.java	Wed Mar 28 14:34:20 2018 +0200
@@ -437,7 +437,7 @@
                 x = getXPathExpression(filter);
             }
             catch (XPathExpressionException xee) {
-                log.warn("Invalid filter expression '" + filter + "'.");
+                log.warn("Invalid filter expression '" + filter + "'.", xee);
                 return rd;
             }
 
@@ -1346,6 +1346,7 @@
     }
 
     /** Handle <dc:statement> elements. */
+    // FIXME: this prohibits using local variables inside of statements!
     protected void compileStatements() {
 
         NodeList nodes = template.getElementsByTagNameNS(


More information about the Dive4Elements-commits mailing list