[PATCH] Removed nonsensiscal cehckstyle options

Wald Commits scm-commit at wald.intevation.org
Thu Aug 13 16:45:04 CEST 2020


# HG changeset patch
# User Gernot Belger <g.belger at bjoernsen.de>
# Date 1597329896 -7200
#      Thu Aug 13 16:44:56 2020 +0200
# Node ID c0803135455c2be42a648b03e1477412afe93f46
# Parent  f4fdf7798bab2442a2befa56e685e1369c81fad8
Removed nonsensiscal cehckstyle options.

diff -r f4fdf7798bab -r c0803135455c checkstyle.xml
--- a/checkstyle.xml	Wed Jul 15 14:25:53 2020 +0200
+++ b/checkstyle.xml	Thu Aug 13 16:44:56 2020 +0200
@@ -7,7 +7,10 @@
 
   <!-- Checks whether files end with a new line.                        -->
   <!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile -->
+  <!--
+    Makes no sense: only necessary for bad text exitors and bad diff tools. 
   <module name="NewlineAtEndOfFile"/>
+   -->
 
   <!-- Checks that property files contain the same keys.         -->
   <!-- See http://checkstyle.sf.net/config_misc.html#Translation -->
@@ -16,11 +19,13 @@
   <module name="FileLength"/>
 
   <!-- Following interprets the header file as regular expressions. -->
+  <!-- FIXME: needs to be adpted for engeneering by several companies. 
   <module name="RegexpHeader">
     <property name="fileExtensions" value="java"/>
     <property name="header"
               value="^/\* Copyright \(C\) .* by Bundesanstalt für Gewässerkunde$\n^ \* Software engineering by .*$\n^ \*$\n^ \* This file is Free Software under the GNU AGPL \(>=v3\)$\n^ \* and comes with ABSOLUTELY NO WARRANTY! Check out the$\n^ \* documentation coming with Dive4Elements River for details.$\n^ \*/$"/>
   </module>
+   -->
 
   <module name="FileTabCharacter">
     <property name="eachLine" value="true"/>
@@ -71,10 +76,11 @@
 
     <!-- Checks for Size Violations.                    -->
     <!-- See http://checkstyle.sf.net/config_sizes.html -->
+    <!-- Checks for 80 chars per line... we did this back in the 1980's...
     <module name="LineLength">
       <property name="ignorePattern" value="^ *\$wnd.*$"/>
     </module>
-
+    -->
 
     <!-- Checks for whitespace                               -->
     <!-- See http://checkstyle.sf.net/config_whitespace.html -->


More information about the Dive4Elements-commits mailing list