[Gpa-commits] r836 - in trunk: . src

[scm-commit@wald.intevation.org]

Author: marcus
Date: 2008-03-06 17:00:47 +0100 (Thu, 06 Mar 2008)
New Revision: 836

Modified:
   trunk/TODO
   trunk/src/ChangeLog
   trunk/src/settingsdlg.c
Log:
2008-03-06  Marcus Brinkmann  <marcus at g10code.de>

	* settingsdlg.c (default_keyserver_frame): Invoke
	keyserver_selected_cb on focus-out-event rather than activated.


Modified: trunk/TODO
===================================================================
--- trunk/TODO	2008-03-05 10:12:57 UTC (rev 835)
+++ trunk/TODO	2008-03-06 16:00:47 UTC (rev 836)
@@ -40,8 +40,8 @@
 
 * MB:
 ** Support getting plaintext from verify operation (should emit "created file"
-   then).  NEEDED FOR CLIPBOARD of non clear text.
-** Fix gpgconf support in windows (gpgme bug?).
+   then).  NEEDED FOR CLIPBOARD of non clear text.  And also needed
+   for normal file ops.
 
 ** Convert the windows registry strings for the home dir to the glib filename
    encoding, or rather to utf8 and from there to the glib filename encoding.
@@ -61,3 +61,11 @@
    parent.  Maybe it is realized too early due to init vs constructor?
    It does get the right parent window parameter (checked that).
 ** Use GtkAction instead of manual GLists for update sensitivity and stuff.
+** Not all users know about ctrl+click to select multiple items from a list.
+   Use check boxes, or add instructions, or otherwise make this
+   easier.
+** The keyring editor has a pop up if there is no default key that says
+   that the user has no private key.  But the user can have a private key.
+   Either fix the message or the check.
+** The keyserver setting should remember the strings entered by the user.
+

Modified: trunk/src/ChangeLog
===================================================================
--- trunk/src/ChangeLog	2008-03-05 10:12:57 UTC (rev 835)
+++ trunk/src/ChangeLog	2008-03-06 16:00:47 UTC (rev 836)
@@ -1,3 +1,8 @@
+2008-03-06  Marcus Brinkmann  <marcus at g10code.de>
+
+	* settingsdlg.c (default_keyserver_frame): Invoke
+	keyserver_selected_cb on focus-out-event rather than activated.
+
 2008-03-05  Werner Koch  <wk at g10code.com>
 
 	* server.c (struct conn_ctrl_s): Add field GPA_OP.

Modified: trunk/src/settingsdlg.c
===================================================================
--- trunk/src/settingsdlg.c	2008-03-05 10:12:57 UTC (rev 835)
+++ trunk/src/settingsdlg.c	2008-03-06 16:00:47 UTC (rev 836)
@@ -98,8 +98,8 @@
   gtk_entry_set_text (GTK_ENTRY (GTK_COMBO (combo)->entry),
                       gpa_options_get_default_keyserver 
 		      (gpa_options_get_instance ()));
-  /* Connect signals */
-  g_signal_connect (G_OBJECT (GTK_COMBO (combo)->entry), "activate",
+  /* Connect signals.  Try to follow instant-apply principle.  */
+  g_signal_connect (G_OBJECT (GTK_COMBO (combo)->entry), "focus-out-event",
                     G_CALLBACK (keyserver_selected_cb), NULL);
   g_signal_connect (G_OBJECT (GTK_COMBO (combo)->list), "select-child",
                     G_CALLBACK (selected_from_list_cb),