[Mpuls-commits] r3113 - in base/trunk: . mpulsweb/controllers

[scm-commit@wald.intevation.org]

Author: bh
Date: 2010-07-02 12:24:05 +0200 (Fri, 02 Jul 2010)
New Revision: 3113

Modified:
   base/trunk/ChangeLog
   base/trunk/mpulsweb/controllers/formularpage.py
Log:
* mpulsweb/controllers/formularpage.py: Remove an except clause
that only logs the exception and then reraises it.  Logging should
already be handled by the pylons system in some way, so there's no
need to do it again here.
Also, redirections are implemented as exceptions, so that the
exceptions for the redirections for the repeat group new/delete
actions would also be logged as exceptions.  These were logged as
errors by this except clause leading to the false impression that
they were errors.


Modified: base/trunk/ChangeLog
===================================================================
--- base/trunk/ChangeLog	2010-07-02 10:19:47 UTC (rev 3112)
+++ base/trunk/ChangeLog	2010-07-02 10:24:05 UTC (rev 3113)
@@ -1,5 +1,17 @@
 2010-07-02  Bernhard Herzog  <bh at intevation.de>
 
+	* mpulsweb/controllers/formularpage.py: Remove an except clause
+	that only logs the exception and then reraises it.  Logging should
+	already be handled by the pylons system in some way, so there's no
+	need to do it again here.
+	Also, redirections are implemented as exceptions, so that the
+	exceptions for the redirections for the repeat group new/delete
+	actions would also be logged as exceptions.  These were logged as
+	errors by this except clause leading to the false impression that
+	they were errors.
+
+2010-07-02  Bernhard Herzog  <bh at intevation.de>
+
 	* mpulsweb/controllers/formularpage.py
 	(FormularpageController.save): Make sure not use routes memory
 	when generating the redirection URLs for the deletion/addition of

Modified: base/trunk/mpulsweb/controllers/formularpage.py
===================================================================
--- base/trunk/mpulsweb/controllers/formularpage.py	2010-07-02 10:19:47 UTC (rev 3112)
+++ base/trunk/mpulsweb/controllers/formularpage.py	2010-07-02 10:24:05 UTC (rev 3113)
@@ -224,11 +224,6 @@
             #error_status(_('Error while saving data'))
             session['uncommited_fields'] = instance_tree.commit()
             session.save()
-        except:
-            log.error(traceback.print_exc())
-            #error_status(_('Error while saving data'))
-            raise # Saving failed with unknown reason! Raise exception ->
-                  # should result in a bugreport dialog if enabled.
 
         return self.select(page_id)