[Skencil-devel] [Skencil-commits] r737 - skencil/branches/skencil-0.6/src/Sketch/UI

[Igor Novikov]

On Mon, Sep 27, 2010 at 2:01 PM, Bernhard Herzog <bh at intevation.de> wrote:

> > Modified: skencil/branches/skencil-0.6/src/Sketch/UI/tooltips.py
> > ===================================================================
> > --- skencil/branches/skencil-0.6/src/Sketch/UI/tooltips.py    2010-09-23
> 12:02:00 UTC (rev 736)
> > +++ skencil/branches/skencil-0.6/src/Sketch/UI/tooltips.py    2010-09-24
> 10:33:14 UTC (rev 737)
> > @@ -70,7 +70,23 @@
> >          self.last_widget = widget_name
> >          self.balloon.withdraw()
> >          self.balloon_label['text'] = text
> > -        x = x - self.balloon_label.winfo_reqwidth() / 2
> > +
> > +        width=self.balloon_label.winfo_reqwidth()
> > +        height=self.balloon_label.winfo_reqheight()
> > +
> > +        screenwidth=self.root.winfo_screenwidth()
> > +        screenheight=self.root.winfo_screenheight()
> > +
> > +        x=self.root.winfo_pointerx()+10
> > +        y=self.root.winfo_pointery()+20
> > +
> > +        if screenwidth<(x+width):
> > +            x=x-width
> > +
> > +        if screenheight<(y+height):
> > +            y=y-height-25
> > +
> > +#        x = x - self.balloon_label.winfo_reqwidth() / 2
>
> There's no need to keep the old code around as comments.  Just remove
> it.  Also, please try to keep the coding style consistent.  the new code
> is missing lots of spaces around the binary operators.
>
>  Bernhard
> _______________________________________________
> Skencil-devel mailing list
> Skencil-devel at wald.intevation.org
> http://lists.wald.intevation.org/mailman/listinfo/skencil-devel
>


OK. Thank you for the note. I will check whole source code for commented
pieces because
such obsolete fragments are sometimes found. For example in the same
tooltips.py
module 10 lines below. The same is for code reformatted. I have committed
the fix for
tooltips.py.

We have started sK1 using Skencil 0.6.15 Comparing with current trunk
version I can say
that as a python code and C-extension sources look much more better then
ver.0.6.15
So I will try to keep code consistency.

-- 
Regards,

Igor Novikov
sK1 Project
http://sk1project.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.wald.intevation.org/pipermail/skencil-devel/attachments/20100928/cd219574/attachment.html