[Thuban-commits] r2678 - in trunk/thuban: . Doc/technotes

[scm-commit@wald.intevation.org]

Author: bernhard
Date: 2006-04-20 15:20:48 +0200 (Thu, 20 Apr 2006)
New Revision: 2678

Modified:
   trunk/thuban/ChangeLog
   trunk/thuban/Doc/technotes/coding_guidelines.txt
Log:
* Doc/technotes/coding_guidelines.txt: Changed text from CVS to SVN.
Removed emacs specific hint and replaced it with a general hint
that editors might support writing changelogs.


Modified: trunk/thuban/ChangeLog
===================================================================
--- trunk/thuban/ChangeLog	2006-04-12 09:35:21 UTC (rev 2677)
+++ trunk/thuban/ChangeLog	2006-04-20 13:20:48 UTC (rev 2678)
@@ -1,4 +1,10 @@
+2006-04-20 Bernhard Reiter <bernhard at intevation.de>
+	* Doc/technotes/coding_guidelines.txt: Changed text from CVS to SVN.
+	Removed emacs specific hint and replaced it with a general hint
+	that editors might support writing changelogs.
+
 2006-04-12 Bernhard Reiter <bernhard at intevation.de>
+
 	* Thuban/version.py: Changed thuban_release mechanism to use "svn"
 	instead of "cvs".
 
@@ -12,6 +18,7 @@
 	build on windows. The file is cleaner and nicer now.
 
 2006-03-29  Bernhard Reiter <bernhard at intevation.de>
+
 	* libraries/thuban/wxproj.cpp: undef LP to avoid clash when 
 	trying to build with mingw.
 
@@ -34,7 +41,6 @@
 
 2005-10-17  Bernhard Reiter <bernhard at intevation.de>
 
-
 	* test/test_stringrepresentation.py: New file, for now testing
 	that set_internal_coding() is throwing an exception for bad exceptions.
 

Modified: trunk/thuban/Doc/technotes/coding_guidelines.txt
===================================================================
--- trunk/thuban/Doc/technotes/coding_guidelines.txt	2006-04-12 09:35:21 UTC (rev 2677)
+++ trunk/thuban/Doc/technotes/coding_guidelines.txt	2006-04-20 13:20:48 UTC (rev 2678)
@@ -9,7 +9,7 @@
     To keep the Thuban code maintainable all code should adhere to the
     guidelines outlined below.  The guidelines currently cover stylistic
     issues (e.g. rules for source code formatting) as well as Python
-    programming hints and rules for using CVS and making patches.
+    programming hints and rules for using SVN and making patches.
 
 
 Source Formatting
@@ -98,7 +98,7 @@
       being present.
 
 
-CVS
+SVN
 
     - One can't say this often enough: Before a checkin, run the *entire
       testsuite*.  Yes, all of it.  Even if you think your change won't
@@ -106,30 +106,24 @@
 
     - All commits should be described in the ChangeLog file.  The easiest
       way to do that is to write the ChangeLog entry first and use that
-      as the commit message.
+      as the commit message. Maybe your editor has support to help with this.
 
-      For emacs users: Use emacs' CVS support (e.g. `C-x v =' in a
-      modified file's buffer) to get a diff and then use `C-x 4 a' at
-      appropriate places in the diff to start the ChangeLog entry.
-
     - Try to make small self contained commits.  In particular, if
       during the work on a more complex change you discover a bug,
       commit the the fix to that bug separately with a separate
       ChangeLog entry.
 
-
-
 Patches
 
     - When you produce patches please try to produce them as patches
-      against a current CVS version.  A patch against code from a
+      against a current SVN version.  A patch against code from a
       tarball is often OK too but can make it more difficult to test a
-      patch if e.g. the files in CVs have changed considerably.
+      patch if e.g. the files in SVN have changed considerably.
 
-    - Please make context diffs, i.e. use the -c option of diff or cvs
+    - Please make context diffs, i.e. use the -c or -u option of diff or svn
       diff.  The default output of diff is not suitable for a patch.
 
-    - Treat a patch like CVS commit.  That's what it will end up as if
+    - Treat a patch like SVN commit.  That is what it will end up as if
       it is accepted, so if you want to increase the chances that it
       will be applied, please try to make the work easier for us, and
       make sure the test suite still works, add new tests if your patch