[PATCH] Fix cinstprocesstest for new arguments. Handle errno on write errors

[Wald Commits]

# HG changeset patch
# User Andre Heinecke <aheinecke at intevation.de>
# Date 1398173243 0
# Node ID c88090a15ae4aeb689df8d6fa230bea93fe79d72
# Parent  8f50533027af9bf1526479f1f53383448c78b759
Fix cinstprocesstest for new arguments. Handle errno on write errors

diff -r 8f50533027af -r c88090a15ae4 cinst/nssstore_linux.c
--- a/cinst/nssstore_linux.c	Tue Apr 22 13:00:15 2014 +0000
+++ b/cinst/nssstore_linux.c	Tue Apr 22 13:27:23 2014 +0000
@@ -19,6 +19,7 @@
 #include <string.h>
 #include <stdlib.h>
 #include <limits.h>
+#include <errno.h>
 
 #include "nssstore.h"
 #include "logging.h"
@@ -187,7 +188,7 @@
     {
       if (fprintf (stream, "I:%s\n", to_install[i]) <= 3)
         {
-          ERRORPRINTF ("Write failed \n");
+          ERRORPRINTF ("Write failed: %s \n", strerror(errno));
           goto done;
         }
     }
@@ -196,7 +197,7 @@
     {
       if (fprintf (stream, "R:%s\n", to_remove[i]) <= 3)
         {
-          ERRORPRINTF ("Write failed \n");
+          ERRORPRINTF ("Write failed: %s \n", strerror(errno));
           goto done;
         }
     }
diff -r 8f50533027af -r c88090a15ae4 ui/tests/cinstprocesstest.cpp
--- a/ui/tests/cinstprocesstest.cpp	Tue Apr 22 13:00:15 2014 +0000
+++ b/ui/tests/cinstprocesstest.cpp	Tue Apr 22 13:27:23 2014 +0000
@@ -69,7 +69,7 @@
     }
     instructions.close();
 
-    args << "instructions=" + instructions.fileName();
+    args << "choices=" + instructions.fileName();
 
     QProcess* installerProcess = startCinstProcess(args);
     finishVerify(installerProcess, ERR_NO_ERROR);
@@ -137,7 +137,7 @@
     }
     instructions.close();
 
-    args << "instructions=" + instructions.fileName();
+    args << "choices=" + instructions.fileName();
 
     QProcess* installerProcess = startCinstProcess(args);
     finishVerify(installerProcess, ERR_INVALID_INPUT_NO_LIST);
@@ -157,7 +157,7 @@
     }
     instructions.close();
 
-    args << "instructions=" + instructions.fileName();
+    args << "choices=" + instructions.fileName();
 
     QProcess* installerProcess = startCinstProcess(args);
     /* If the following failed there may be leftovers in /tmp */
@@ -168,7 +168,7 @@
 void CinstProcessTest::testNoInput() {
     QStringList args;
     args << "list=foobazbuf";
-    args << "instructions=bazbuffoo";
+    args << "choices=bazbuffoo";
     QProcess* installerProcess;
     installerProcess = startCinstProcess(args);
     finishVerify(installerProcess, ERR_INVALID_INPUT_NO_LIST);
@@ -183,7 +183,7 @@
 
     QStringList args;
     args << "list=" + validListFile.fileName();
-    args << "instructions=" + emptyFile.fileName();
+    args << "choices=" + emptyFile.fileName();
 
     QProcess* installerProcess = startCinstProcess(args);
     finishVerify(installerProcess, ERR_NO_INSTRUCTIONS);
@@ -202,7 +202,7 @@
     instructions.write("I:ABCDEF\n");
     instructions.close();
 
-    args << "instructions=" + instructions.fileName();
+    args << "choices=" + instructions.fileName();
 
     QProcess* installerProcess = startCinstProcess(args);
 
@@ -212,7 +212,7 @@
 void CinstProcessTest::testUninstall() {
     QStringList args;
     args << "list=" + validListFile.fileName();
-    args << "instructions=uninstall";
+    args << "choices=uninstall";
 
     QProcess* installerProcess = startCinstProcess(args);