[PATCH] (issue152) Do not return CryptUIDlgViewContext's return value

Wald Commits scm-commit at wald.intevation.org
Mon Oct 13 14:13:09 CEST 2014


# HG changeset patch
# User Andre Heinecke <andre.heinecke at intevation.de>
# Date 1413202385 -7200
# Node ID 60e481aa75cafa9698337919d006ba4e1a8e2f82
# Parent  32a44cfb78c0a2eec142b4393bef49799b8b5fbc
(issue152) Do not return CryptUIDlgViewContext's return value

    The return value is false if the user cancels the dialog.
    But as the certificate has been shown this is not really an
    error.

diff -r 32a44cfb78c0 -r 60e481aa75ca ui/certificate.cpp
--- a/ui/certificate.cpp	Mon Oct 13 13:29:19 2014 +0200
+++ b/ui/certificate.cpp	Mon Oct 13 14:13:05 2014 +0200
@@ -234,16 +234,12 @@
         goto done;
     }
 
-    if (!funcPtr(CERT_STORE_CERTIFICATE_CONTEXT,
+    funcPtr(CERT_STORE_CERTIFICATE_CONTEXT,
                  pCert,
                  (HWND) parent,
                  NULL, // Default Title
                  0,
-                 NULL)) {
-        qDebug() << "Failed to view certificate.";
-        retval = false;
-        goto done;
-    }
+                 NULL);
 
     retval = true;
 done:


More information about the Trustbridge-commits mailing list