[Winpt-devel] Re2: Building WinPT

[Oliver Winker]

Yes - it looks good! Doesn't crash anymore on wrong pw. Seems to be fixed. Perfect. 

So c was null. Why didn't it actually display with null or 0x0 on the 'print *c' in gdb, after the sigsegv ? 

Can it be, that the callback is called several times during the decryption action and spoiling the c somehow ? 
While still debugging a bit, I had the impression the cb is called several times per file decryption.

Anyway, Thanks a lot for having this fixed so quickly :)! 

Wasn't really critical of course ... but I think it's nicer if it's not crashing, like for less technical people e.g. .

Do you already know when this would be included in a next release ?


Cheers, Oliver




> -----Ursprüngliche Nachricht-----
> Von: WinPT developer discussion <winpt-devel at wald.intevation.org>
> Gesendet: 14.05.06 17:51:23
> An: WinPT developer discussion <winpt-devel at wald.intevation.org>
> Betreff: Re: [Winpt-devel] Re2:  Building WinPT


> Oliver Winker wrote:
> > When you have something (patch etc.), let me know. I'll check it immediately in my env.
> 
> Currently I've no access to any patch tools so I try to describe the
> patch "manually":
> 
> 
> in wptPassphraseCB.cpp (passphrase_callback):
> 
> -- if (c->cancel) {
> ++ if (c->cancel || !c->pwd) {
> 	if (!WriteFile (hd, "\n", 1, &n, NULL))
> 	    log_debug ("passphrase_cb: WriteFile() failed ec=%d\n",
> 			w32_errno);
> 	return 0;
>      }
> 
> Sorry that I cannot provide any real diff output...
> 
> 
> 	Timo
> 
> _______________________________________________
> Winpt-devel mailing list
> Winpt-devel at wald.intevation.org
> http://lists.wald.intevation.org/mailman/listinfo/winpt-devel