[PATCH] Purge some duplicated logging an misleading comments

Wald Commits scm-commit at wald.intevation.org
Mon Sep 15 15:00:51 CEST 2014


# HG changeset patch
# User "Tom Gottfried <tom at intevation.de>"
# Date 1410786048 -7200
# Node ID f98598cf798c755d42b6f48ca07280e3622ae5bc
# Parent  1cfeab5e9a60fc080e678436e3e97ce83c8483d4
Purge some duplicated logging an misleading comments.

diff -r 1cfeab5e9a60 -r f98598cf798c artifacts/src/main/java/org/dive4elements/river/artifacts/context/RiverContext.java
--- a/artifacts/src/main/java/org/dive4elements/river/artifacts/context/RiverContext.java	Mon Sep 15 11:58:31 2014 +0200
+++ b/artifacts/src/main/java/org/dive4elements/river/artifacts/context/RiverContext.java	Mon Sep 15 15:00:48 2014 +0200
@@ -109,7 +109,7 @@
         GeneratorLookup.Item item = generators.getGenerator(name);
 
         if (item == null) {
-            log.warn("No generator class found for " + name);
+            log.error("No generator class found for " + name);
             return null;
         }
 
diff -r 1cfeab5e9a60 -r f98598cf798c artifacts/src/main/java/org/dive4elements/river/artifacts/model/sq/SQMeasurementFacet.java
--- a/artifacts/src/main/java/org/dive4elements/river/artifacts/model/sq/SQMeasurementFacet.java	Mon Sep 15 11:58:31 2014 +0200
+++ b/artifacts/src/main/java/org/dive4elements/river/artifacts/model/sq/SQMeasurementFacet.java	Mon Sep 15 15:00:48 2014 +0200
@@ -23,7 +23,7 @@
 
 
 /**
- * Facet to show the outliers in a sq relation.
+ * Facet to show the measured values in a sq relation.
  *
  * @author <a href="mailto:ingo.weinzierl at intevation.de">Ingo Weinzierl</a>
  */
diff -r 1cfeab5e9a60 -r f98598cf798c artifacts/src/main/java/org/dive4elements/river/artifacts/model/sq/SQOutlierFacet.java
--- a/artifacts/src/main/java/org/dive4elements/river/artifacts/model/sq/SQOutlierFacet.java	Mon Sep 15 11:58:31 2014 +0200
+++ b/artifacts/src/main/java/org/dive4elements/river/artifacts/model/sq/SQOutlierFacet.java	Mon Sep 15 15:00:48 2014 +0200
@@ -24,7 +24,7 @@
 import org.apache.log4j.Logger;
 
 /**
- * Facet to show the curve in a sq relation.
+ * Facet to show the outliers in a sq relation.
  *
  * @author <a href="mailto:ingo.weinzierl at intevation.de">Ingo Weinzierl</a>
  */
diff -r 1cfeab5e9a60 -r f98598cf798c artifacts/src/main/java/org/dive4elements/river/collections/D4EArtifactCollection.java
--- a/artifacts/src/main/java/org/dive4elements/river/collections/D4EArtifactCollection.java	Mon Sep 15 11:58:31 2014 +0200
+++ b/artifacts/src/main/java/org/dive4elements/river/collections/D4EArtifactCollection.java	Mon Sep 15 15:00:48 2014 +0200
@@ -388,7 +388,6 @@
         OutGenerator generator = RiverContext.getOutGenerator(context, key);
 
         if (generator == null) {
-            log.error("There is no generator specified for output: " + name);
             // TODO Throw an exception.
 
             return;


More information about the Dive4Elements-commits mailing list